Fix textual things not updating on the first change (#4219)

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
openhab · May 6, 2024 · 456d5d3 · 456d5d3
1 parent d083a53
commit 456d5d3
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/...hab.core.model.thing/src/org/openhab/core/model/thing/internal/GenericThingProvider.xtend b/...hab.core.model.thing/src/org/openhab/core/model/thing/internal/GenericThingProvider.xtend
@@ -605,8 +605,9 @@ class GenericThingProvider extends AbstractProviderLazyNullness<Thing> implement
         if (!loadedXmlThingTypes.contains(factory.bundleName) || modelRepository == null) {
             return
         }
+        val things = thingsMap.get(modelName)
+        val oldThings = things.clone
         val newThings = newArrayList()
-        val oldThings = thingsMap.put(modelName, newThings)
 
         val model = modelRepository.getModel(modelName) as ThingModel
         if (model !== null) {
@@ -619,10 +620,13 @@ class GenericThingProvider extends AbstractProviderLazyNullness<Thing> implement
             val oldThing = oldThings.findFirst[it.UID == newThing.UID]
             if (oldThing !== null) {
                 if (!ThingHelper.equals(oldThing, newThing)) {
+                    things.remove(oldThing)
+                    things.add(newThing)
                     logger.debug("Updating thing '{}' from model '{}'.", newThing.UID, modelName);
                     notifyListenersAboutUpdatedElement(oldThing, newThing)
                 }
             } else {
+                things.add(newThing)
                 logger.debug("Adding thing '{}' from model '{}'.", newThing.UID, modelName);
                 newThing.notifyListenersAboutAddedElement
             }