Fix SerialPort.getFlowControlMode() infinite recursion (#4007)

An infinite recursion would occur when calling this method. I did not find any add-ons using this method but that could be due to this bug. Signed-off-by: Wouter Born <github@maindrain.net>
openhab · Jan 3, 2024 · f71b062 · f71b062
1 parent e3180c4
commit f71b062
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/....javacomm/src/main/java/org/openhab/core/io/transport/serial/internal/SerialPortImpl.java b/....javacomm/src/main/java/org/openhab/core/io/transport/serial/internal/SerialPortImpl.java
@@ -206,7 +206,7 @@ public void notifyOnCarrierDetect(boolean enable) {
 
     @Override
     public int getFlowControlMode() {
-        return getFlowControlMode();
+        return sp.getFlowControlMode();
     }
 
     @Override

diff --git a/...t.serial.rxtx/src/main/java/org/openhab/core/io/transport/serial/rxtx/RxTxSerialPort.java b/...t.serial.rxtx/src/main/java/org/openhab/core/io/transport/serial/rxtx/RxTxSerialPort.java
@@ -206,7 +206,7 @@ public void notifyOnCarrierDetect(boolean enable) {
 
     @Override
     public int getFlowControlMode() {
-        return getFlowControlMode();
+        return sp.getFlowControlMode();
     }
 
     @Override