Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing roles checks #1739

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Add missing roles checks #1739

merged 1 commit into from
Oct 20, 2020

Commits on Oct 19, 2020

  1. Add missing roles checks 

    (I included these fixes in openhab#1735 but extracted them in a stanalone
PR because it's easier to review and a little more urgent.)

As a result of the refactoring in openhab#1713, the operations annotated with
`@RolesAllowed` containing `Role.USER` are not anymore automatically
considered accessible to all users, regardless of their actual roles.

4 operations are therefore now denied to admins if they only have the
`Role.ADMIN` role, as the first admininistrator is created only with
that role the UI encounters unexpected access denied errors and breaks.
(See openhab/openhab-webui#422).

Closes openhab/openhab-webui#422.

Signed-off-by: Yannick Schaus <github@schaus.net>
    @ghys
    ghys committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    aa5ec58 View commit details
    Browse the repository at this point in the history