[Marketplace] Add option to include unpublished entries #2488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a config parameter to bypass the filtering of Dicourse topics to include those which don't have the "published" tag. Set the API key parameter as advanced (irrelevant to most users). Signed-off-by: Yannick Schaus <github@schaus.net>
|
What exactly is the use case to show unpublished stuff? I thought the whole idea is to only show entries with the published tag as all the rest is not (yet) meant to be shown in the marketplace? |
|
Yes, the default is to not show them. This option is mostly for the authors themselves and moderators so they can preview draft entries in the marketplace before regular users see them, and see if they work - hence the strongish language in the description ("harm your installation", "at your own risk" etc.) but it's true, there's still a risk people who have no business enabling this option will still try it. |
|
Ok, let's see if this causes issues as too many people activate it and then complain... |
kaikreuzer
approved these changes
Sep 16, 2021
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Add a config parameter to bypass the filtering of Dicourse topics to include those which don't have the "published" tag. Set the API key parameter as advanced (irrelevant to most users). Signed-off-by: Yannick Schaus <github@schaus.net> GitOrigin-RevId: 0ef477e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a config parameter to bypass the filtering of Dicourse topics
to include those which don't have the "published" tag.
Set the API key parameter as advanced (irrelevant to most users).
Signed-off-by: Yannick Schaus github@schaus.net