-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"System reached start level XX" trigger for DSL rules #2658
Conversation
e19815a
to
4e3d675
Compare
Signed-off-by: Flole <flole@flole.de>
4e3d675
to
9c38357
Compare
What exactly is the intention here? The lowest start level that allows execution of rules is 40/50 when the "system started ones are triggered". Besides this, there are no higher start levels implemented so far, so I do not really see any use case here (yet)? |
There are 4 reasons I did this (and you will probably only consider one or two of them a valid reason ;) ):
Anyways, I understand your concern about this being potentially confusing. To fix that I suggest adding a warning if a startup level < 40 is supplied that "Rules can not be executed until start level 40 is reached". We would also have to change the documentation which is currently stating We can also put this aside until other levels are implemented, but with proper documentation and even a warning in the logs it should do no harm to merge it now, even though the full use case will only be visible later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your explanation @Flole998!
Fine for me to add this so that DSL-rules have the same features as UI-rules.
Maybe then worth to pick up the implementation for higher start levels soon. ;-)
Could you be so kind to also provide a PR for the documentation?
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
…penhab#2658) Signed-off-by: Flole <flole@flole.de> GitOrigin-RevId: b6bac8d
This implements a way to trigger dsl-based rules on various start levels, like it is already possible with ui-based rules.