Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rest] Do not reuse FilterCriteria instance for more than one query #2668

Merged
merged 2 commits into from
Jan 15, 2022
Merged

[rest] Do not reuse FilterCriteria instance for more than one query #2668

merged 2 commits into from
Jan 15, 2022

Conversation

cweitkamp
Copy link
Contributor

@cweitkamp cweitkamp commented Jan 5, 2022 •
edited
Loading

  • Do not reuse FilterCriteria instance for more than one query

Closes #2665

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

@cweitkamp cweitkamp added bug An unexpected problem or unintended behavior of the Core REST/SSE persistence labels Jan 5, 2022
@cweitkamp cweitkamp requested a review from a team as a code owner January 5, 2022 14:35
@cweitkamp cweitkamp mentioned this pull request Jan 5, 2022
Closed
@cweitkamp cweitkamp force-pushed the bugfix-2665-rest-persistence-boundary branch from c3e7318 to f36405c Compare January 6, 2022 07:13
wborn
wborn reviewed Jan 15, 2022
View reviewed changes
Copy link
Member

@wborn wborn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, but I have a question below.
Can you also fix the merge conflicts?

...re/src/main/java/org/openhab/core/io/rest/core/internal/persistence/PersistenceResource.java Outdated Show resolved Hide resolved
@cweitkamp
Do not reuse FilterCriteria instance for more than one query
e802a00 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp
Incorported comments from review
81e8ce9 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp force-pushed the bugfix-2665-rest-persistence-boundary branch from f36405c to 81e8ce9 Compare January 15, 2022 15:30
@cweitkamp
Copy link
Contributor Author

I fixed the conflicts and removed the check if the item exists.

@cweitkamp cweitkamp mentioned this pull request Jan 15, 2022
Merged
@cweitkamp
Copy link
Contributor Author

@wborn I changed my implementation for JDBC too: openhab/openhab-addons#12052

wborn
wborn approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 0dbc2b2 into openhab:main Jan 15, 2022
@wborn wborn added this to the 3.3 milestone Jan 15, 2022
@cweitkamp cweitkamp deleted the bugfix-2665-rest-persistence-boundary branch January 15, 2022 16:21
@cweitkamp cweitkamp mentioned this pull request Jan 3, 2023
Closed
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@cweitkamp @splatch
[rest] Do not reuse FilterCriteria instance for more than one query (o…
1b12352 
…penhab#2668)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
GitOrigin-RevId: 0dbc2b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core persistence REST/SSE
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

requesting persistence data with boundary parameter does not seem to include end date datapoint
2 participants
@cweitkamp @wborn