Fix broken config validation for required parameters #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
wborn
reviewed
Jan 15, 2022
...st/java/org/openhab/core/config/core/internal/validation/ConfigDescriptionValidatorTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan N. Klug <github@klug.nrw>
wborn
changed the title
wborn
added a commit
to wborn/openhab-addons
that referenced
this pull request
Jan 15, 2022
The validation did not fail previously because it was broken and fixed in openhab/openhab-core#2683 Signed-off-by: Wouter Born <github@maindrain.net>
wborn
added a commit
to wborn/openhab-addons
that referenced
this pull request
Jan 15, 2022
The validation did not fail previously because it was broken and fixed in openhab/openhab-core#2683 Signed-off-by: Wouter Born <github@maindrain.net>
wborn
added a commit
to wborn/openhab-addons
that referenced
this pull request
Jan 15, 2022
The validation did not fail previously because it was broken and fixed in openhab/openhab-core#2683 Signed-off-by: Wouter Born <github@maindrain.net>
jlaur
pushed a commit
to openhab/openhab-addons
that referenced
this pull request
Jan 15, 2022
#12056) The validation did not fail previously because it was broken and fixed in openhab/openhab-core#2683 Signed-off-by: Wouter Born <github@maindrain.net>
moesterheld
pushed a commit
to moesterheld/openhab-addons
that referenced
this pull request
Jan 18, 2022
openhab#12056) The validation did not fail previously because it was broken and fixed in openhab/openhab-core#2683 Signed-off-by: Wouter Born <github@maindrain.net>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
openhab#12056) The validation did not fail previously because it was broken and fixed in openhab/openhab-core#2683 Signed-off-by: Wouter Born <github@maindrain.net>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
openhab#12056) The validation did not fail previously because it was broken and fixed in openhab/openhab-core#2683 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
openhab#12056) The validation did not fail previously because it was broken and fixed in openhab/openhab-core#2683 Signed-off-by: Wouter Born <github@maindrain.net>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
openhab#12056) The validation did not fail previously because it was broken and fixed in openhab/openhab-core#2683 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: dff5fde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConfigDescriptionValidatorimplementation did not iterate over the content of theConfigDescriptionbut over the content of the provided configuration. As a result parameters that were missing (and not just set tonull) are not detected.Tests results are re-ordered due to fixed typos.
Signed-off-by: Jan N. Klug github@klug.nrw