[config] Add config validator for parameter options #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweitkamp
added
enhancement
kaikreuzer
changed the title
J-N-K
reviewed
Feb 1, 2022
| } | ||
|
|
||
| // Option values are a string, so we can do a simple compare | ||
| if (!param.getOptions().stream().map(o -> o.getValue()).anyMatch(v -> v.equals(value.toString()))) { |
| // Option values are a string, so we can do a simple compare | ||
| if (!param.getOptions().stream().map(o -> o.getValue()).anyMatch(v -> v.equals(value.toString()))) { | ||
| MessageKey messageKey = MessageKey.OPTIONS_VIOLATED; | ||
| return new ConfigValidationMessage(param.getName(), messageKey.defaultMessage, messageKey.key); |
There was a problem hiding this comment.
It would be nice to add the list of allowed options here. This might be helpful to correct the setting.
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
force-pushed
the
feature-config-options-validation
branch
from
1501b47
to
2e53959
Compare
J-N-K
requested changes
Feb 7, 2022
There was a problem hiding this comment.
A general comment: IMO ConfigDescriptionParameterValidatorFactory should be removed. There is no need for it, it just returns a new instance which could also be achieved by inserting new ... in the map. But maybe we should put that in another PR (like removing the unnecessary checks we talked about in #2690.
| // =========================================================================== | ||
|
|
||
| @Test | ||
| public void assertValidationThrowsNoExceptionForAllowedLimitedParameterOption() { |
There was a problem hiding this comment.
For other validations we assert valid parameters pass the validation by adding a valid value in setUp. To keep it consistent, we should do the same here and only keep a separate test for the invalid one.
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
J-N-K
approved these changes
Feb 8, 2022
wborn
approved these changes
Feb 9, 2022
This was referenced Nov 6, 2022
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> GitOrigin-RevId: 9cda2c8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2690
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de