Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Enable missing validations #2720

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 31, 2022

The limitToOptions and multipleLimit attributes were not validated. Unused MessageKeys have been removed for checks that can't be configured (attributes not available in config-description).

For reviewing the changes it's best to do it for each commit instead of full-diff.

@J-N-K J-N-K requested a review from a team as a code owner January 31, 2022 20:02
@cweitkamp
Copy link
Contributor

The limitToOptions validation looks very similar to my PR #2691.

@J-N-K
Copy link
Member Author

J-N-K commented Feb 1, 2022

Look like it‘s good code then. I‘ll remove it here.

@J-N-K J-N-K force-pushed the feature-validation-multipleLimit branch from da45ffe to 24bc40a Compare February 1, 2022 10:44
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K force-pushed the feature-validation-multipleLimit branch from 24bc40a to a352728 Compare February 1, 2022 11:22
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp added the enhancement An enhancement or new feature of the Core label Feb 1, 2022
@cweitkamp cweitkamp added this to the 3.3 milestone Feb 1, 2022
@cweitkamp cweitkamp merged commit 8c16cb6 into openhab:main Feb 1, 2022
@J-N-K J-N-K deleted the feature-validation-multipleLimit branch February 1, 2022 16:31
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
* enable validation for multipleLimit
* remove unused validation messages

Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: 8c16cb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants