Fix context being re-used for next execution #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trigger information is inserted in the execution context. This information is changed to the new information each time the context is updated with the same keys. If the context of the next execution does not contain values for each key, the old key is re-used, leading e.g. to wrong event information in the context. The solution is to re-set the individual context after each execution. Signed-off-by: Jan N. Klug <github@klug.nrw>
cweitkamp
added
bug
|
This is not just DSL, it affects all JSR-223 rule engines, too. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
wborn
reviewed
Feb 17, 2022
.../org/openhab/core/automation/module/script/internal/handler/AbstractScriptModuleHandler.java
Outdated
Show resolved
Hide resolved
…a/org/openhab/core/automation/module/script/internal/handler/AbstractScriptModuleHandler.java
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/triggeringitemname-fails-with-cron/135210/3 |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Trigger information is inserted in the execution context. This information is changed to the new information each time the context is updated with the same keys. If the context of the next execution does not contain values for each key, the old key is re-used, leading e.g. to wrong event information in the context. The solution is to re-set the individual context after each execution. Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: 6906927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2751
Trigger information is inserted in the execution context. This information is changed to the new information each time the context is updated with the same keys. If the context of the next execution does not contain values for each key, the old key is re-used, leading e.g. to wrong event information in the context.
The solution is to remove the content of the triggering context after each execution.
Signed-off-by: Jan N. Klug github@klug.nrw