Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rule] New actions to start/stop dialog processing #2791

Merged
merged 6 commits into from
Feb 23, 2022

Conversation

lolodomo
Copy link
Contributor

Related to #2688

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo requested a review from a team as a code owner February 20, 2022 17:12
@wborn wborn added the enhancement An enhancement or new feature of the Core label Feb 20, 2022
Related to openhab#2688

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
Copy link
Contributor Author

@GiviMAD for information

@GiviMAD
Copy link
Member

GiviMAD commented Feb 20, 2022

@lolodomo thanks for pinging me I didn't know about the ActionServices, I think is want I need to expose some actions from the HLI I'm building.

@lolodomo
Copy link
Contributor Author

You should have commented in the issue as your comments are not directly related to my PR.

@GiviMAD
Copy link
Member

GiviMAD commented Feb 20, 2022

You should have commented in the issue as your comments are not directly related to my PR.

Moved there, sorry.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks.

Please also do a PR to openhab-docs, so that the new actions are covered there.

@kaikreuzer kaikreuzer merged commit c0b5f09 into openhab:main Feb 23, 2022
@kaikreuzer kaikreuzer added this to the 3.3 milestone Feb 23, 2022
@lolodomo lolodomo deleted the voice_action_dialog branch February 23, 2022 22:53
@lolodomo
Copy link
Contributor Author

Please also do a PR to openhab-docs, so that the new actions are covered there.

I will do it when my other PR is merged (at it also adds new actions).

splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
* [rule] New actions to start/stop dialog processing

Related to openhab#2688

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
GitOrigin-RevId: c0b5f09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants