Add accepted types to ProfileContext #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
J-N-K
force-pushed
the
feature-profilecontext
branch
from
a72c1d3
to
e538140
Compare
cweitkamp
approved these changes
Mar 13, 2022
Comment on lines
40
to
44
| public ProfileContextImpl(Configuration configuration) { | ||
| this.configuration = configuration; | ||
| this.acceptedDataTypes = List.of(); | ||
| this.acceptedCommandTypes = List.of(); | ||
| } |
There was a problem hiding this comment.
Should we reuse the second ctor here?
Suggested change
| public ProfileContextImpl(Configuration configuration) { | |
| this.configuration = configuration; | |
| this.acceptedDataTypes = List.of(); | |
| this.acceptedCommandTypes = List.of(); | |
| } | |
| public ProfileContextImpl(Configuration configuration) { | |
| this(configuration, List.of(), List.of()); | |
| } |
Signed-off-by: Jan N. Klug <github@klug.nrw>
cweitkamp
approved these changes
Mar 13, 2022
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* Add accepted types to ProfileContext Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: 73b76fa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a very generic script profile which can be used with every item type. E.g. a script could half all commands from the handler to the item. Since a
Dimmerchannel accepts different item types, I need to know which types are accepted by the receiving item. This could e.g. also be used to link aStringchannel (containing a JSON array as result of an HTTP request) to anNumberitem (for element count in the array).Even tough I doubt that there are other implementations of
ProfileContextout there, I decided to keep it backward compatible and make the implementation of the newly introduced methods optional. If you don't mind the breaking change, I can easily remove them.Signed-off-by: Jan N. Klug github@klug.nrw