Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show config validation messages in thing status #2829

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Mar 10, 2022

Following up a discussion in the forum this does not log the validation errors at DEBUG level but adds them as thing status detail message, so it can be shown in the UI.

Signed-off-by: Jan N. Klug github@klug.nrw

@J-N-K J-N-K requested a review from a team as a code owner March 10, 2022 16:00
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-3-3-milestone-discussion/132715/57

@wborn wborn added the enhancement An enhancement or new feature of the Core label Mar 13, 2022
@J-N-K J-N-K force-pushed the feature-betterdisplayofconfigvalidation branch from 02a55f7 to 480f04c Compare March 15, 2022 17:50
@J-N-K
Copy link
Member Author

J-N-K commented Mar 15, 2022

I rebased and incorporated your comment.

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K force-pushed the feature-betterdisplayofconfigvalidation branch from 480f04c to 9ec183b Compare March 16, 2022 15:47
Signed-off-by: Jan N. Klug <github@klug.nrw>
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp merged commit 2686102 into openhab:main Mar 17, 2022
@cweitkamp cweitkamp added this to the 3.3 milestone Mar 17, 2022
@J-N-K J-N-K deleted the feature-betterdisplayofconfigvalidation branch March 17, 2022 14:24
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
* Show config validation messages in thing status

Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: 2686102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants