Fix UnitUtils.getDimensionName returns Angle instead of Dimensionless #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
force-pushed
the
fix-getdimensionname
branch
2 times, most recently
from
a8802db
to
7d8014a
Compare
An Angle is also Dimensionless and because it is the first compatible unit it is always returned instead of any other Dimensionless unit. With these changes `getDimensionName` will prefer the dimension of equal units over those of compatible units. Fixes openhab#2880 Signed-off-by: Wouter Born <github@maindrain.net>
wborn
force-pushed
the
fix-getdimensionname
branch
from
7d8014a
to
380626c
Compare
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
…openhab#2895) An Angle is also Dimensionless and because it is the first compatible unit it is always returned instead of any other Dimensionless unit. With these changes `getDimensionName` will prefer the dimension of equal units over those of compatible units. Fixes openhab#2880 Signed-off-by: Wouter Born <github@maindrain.net> GitOrigin-RevId: a4353ee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Angle is also Dimensionless and because it is the first compatible unit it is always returned instead of any other Dimensionless unit.
With these changes
getDimensionNamewill prefer the dimension of equal units over those of compatible units.Fixes #2880