Add visibility and color parameters to UI sitemap provider #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/sitemap-future-considerations/138517/9 |
J-N-K
requested changes
Sep 3, 2022
...ore.ui/src/main/java/org/openhab/core/ui/internal/components/UIComponentSitemapProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
J-N-K
requested changes
Sep 5, 2022
...ore.ui/src/main/java/org/openhab/core/ui/internal/components/UIComponentSitemapProvider.java
Outdated
Show resolved
Hide resolved
...ore.ui/src/main/java/org/openhab/core/ui/internal/components/UIComponentSitemapProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
J-N-K
approved these changes
Sep 6, 2022
|
Thanks! |
J-N-K
added
enhancement
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
) * add visibility and color parameters Signed-off-by: Mark Herwege <mark.herwege@telenet.be> GitOrigin-RevId: c61ea77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the missing parameters to the sitemap provider. This allows the UI to be further extended in a follow-up PR and make the sitemap UI configuration support the same features as textual configuration.
Signed-off-by: Mark Herwege mark.herwege@telenet.be