Allow sending IncreaseDecreaseType directly to DimmerItem #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Cutrer <cody@cutrer.us>
kaikreuzer
approved these changes
Oct 17, 2022
|
Indeed, that‘s strange, as e.g. Wemo Dimmer brightness channel accepts increase/decrease command since it was implemented years ago. Same for other bindings. |
|
Rules generally use the message bus to send commands, which doesn't use these methods. The HomeKit addon for reasons I'm unsure of calls send directly on items. I've been adding more accessory types to HomeKit, and I've run into a couple of these direct-send overloads that didn't exist. |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Cody Cutrer <cody@cutrer.us> GitOrigin-RevId: ccdf2c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.