Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix only first group config considered in PersistenceManager #3618

Merged
merged 1 commit into from
May 18, 2023
Merged

Fix only first group config considered in PersistenceManager #3618

merged 1 commit into from
May 18, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented May 18, 2023

Fixes #3617

@J-N-K
Fix only first group config considered in persistence manager
b6c6b79 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added bug An unexpected problem or unintended behavior of the Core regression labels May 18, 2023
@J-N-K J-N-K requested a review from a team as a code owner May 18, 2023 07:05
@lolodomo
Copy link
Contributor

Tested and I can confirm it fixes the regression I noticed yesterday.
I believe it should be tagged "Critical".
@openhab/core-maintainers : please merge ASAP and at least before the release of milestone 3.

@J-N-K J-N-K added rebuild Triggers the Jenkins PR build critical and removed rebuild Triggers the Jenkins PR build labels May 18, 2023
kaikreuzer
kaikreuzer approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit d87007a into openhab:main May 18, 2023
@kaikreuzer kaikreuzer added this to the 4.0 milestone May 18, 2023
@J-N-K J-N-K deleted the fix-persistence branch May 18, 2023 09:01
@lolodomo
Copy link
Contributor

@kaikreuzer : there was no new snapshot built this morning while core was properly built. Can you please trigger a new snapshot manually? This will allow testing this fix inside a real snapshot.

@kaikreuzer
Copy link
Member

@lolodomo Done.

splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@J-N-K @splatch
Fix only first group config considered in persistence manager (openha…
d429898 
…b#3618)

Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: d87007a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core critical regression
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Item value no more persisted => problem in persistence strategy loading ?
3 participants
@J-N-K @lolodomo @kaikreuzer