Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed circular dependency in Home Builder and switched tiles to DS annotations #386

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer kaikreuzer commented Aug 20, 2018

Fixes #297

Signed-off-by: Kai Kreuzer kai@openhab.org

…annotations

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member Author

@kubawolanin FYI, I split the servlet registration from the tile declaration.

Copy link
Contributor

@htreu htreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always good to also see more XML being replaced with DS annotations. 👍

@wborn wborn merged commit 11acfba into openhab:master Aug 20, 2018
wborn pushed a commit to wborn/openhab-core that referenced this pull request Sep 10, 2018
…annotations (openhab#386)

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-startup-errors-basicui-circular-references-bindings/52265/3

@martinvw martinvw added this to the 2.4 milestone Dec 9, 2018
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
…annotations (openhab#386)

Signed-off-by: Kai Kreuzer <kai@openhab.org>
GitOrigin-RevId: 11acfba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants