-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve description of hysteresis bounds #4149
Conversation
Signed-off-by: Denis Tarasov <dstarasov@skbkontur.ru>
Signed-off-by: Denis Tarasov <dstarasov@skbkontur.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In SystemProfiles_XX.properties
, these texts are translated to 15-20 languages. These are not adjusted accordingly, but it might be hard for the contributor to do so.
@@ -5,9 +5,9 @@ profile.config.system.offset.offset.label = Смещение | |||
profile.config.system.offset.offset.description = Смещение (просто число или с ед. измерения), применяемое к состоянию по отношению к элементу. Отрицательное смещение будет применено в обратном направлении. | |||
profile-type.system.hysteresis.label = Гистерезис | |||
profile.config.system.hysteresis.lower.label = Нижняя граница | |||
profile.config.system.hysteresis.lower.description = Приводит к состоянию OFF, если значение меньше нижней границы (просто число или с ед. измерения). | |||
profile.config.system.hysteresis.lower.description = Приводит к состоянию OFF, если значение меньше или равно нижней границе (просто число или с ед. измерения). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove these translations (only keep the XML changes and the English) and add it later using crowdin. Otherwise it'll not show up there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Hello,
I found that hysteresis value mapping works differently than stated in its documentation:
source:
doc:
I thought that changing the value mapping would be more correct and opened PR #4120, but during the discussion we decided that it would be preferable to improve the documentation