[ephemeris] Added Ephemeris service #506

kaikreuzer · 2019-02-01T10:00:09Z

Ported over from eclipse-archived/smarthome#6227.

@maggu2810 Did I do it correctly to add the jollyday lib to the compile- and runtime-bom?

Also-by: Gaël L'hopital gael@lhopital.org
Signed-off-by: Kai Kreuzer kai@openhab.org

kaikreuzer · 2019-02-01T13:53:26Z

@maggu2810 Did I do it correctly to add the jollyday lib to the compile- and runtime-bom?

Correction: ...to the compile-bom, runtime-bom AND the bundle pom itself?

maggu2810

Added some minor comments.
I also reviewed (a little bit) the code regardless if it has "only" been ported...

maggu2810 · 2019-02-01T15:33:11Z

bundles/org.openhab.core.ephemeris/pom.xml

+      <artifactId>org.openhab.core.config.core</artifactId>
+      <version>${project.version}</version>
+    </dependency>
+    <dependency>


Please do not add any external dependency here.
That should be injected by the compile BOM already.

That's what I expected as well. But as you can see here, the PR build failed without it and once I added it, it succeeded. Any idea why?

On my machine it is working (building the project after removing that lines).

Looking at the check of the first commit:

continuous-integration/travis-ci/pr: success

PR-openHAB-Core: failure

I assume you should check your Jenkins configuration.

IMHO my comment is still valid and should be addressed.

Definitely - sorry, it slipped through. Fixed now.

...emeris/src/main/java/org/eclipse/smarthome/core/ephemeris/internal/EphemerisManagerImpl.java

features/karaf/openhab-core/src/main/feature/feature.xml

kaikreuzer · 2019-02-01T20:32:36Z

@maggu2810 Any idea why travis failed? Did I do anything wrong wrt capability/requirement?

maggu2810 · 2019-02-01T21:24:10Z

You define a capability but no option how it could be resolved it is it not already be resolved by the current environment.
We always add a optional dependency to a feature.

See:

openhab-core/features/karaf/openhab-core/src/main/feature/feature.xml

Lines 23 to 33 in 89a54e5

    
           <requirement>openhab.tp;filter:="(feature=base)"</requirement> 
        
           <feature dependency="true">openhab.tp-base</feature> 
        
           <requirement>openhab.tp;filter:="(&amp;(feature=xtext)(version&gt;=2.14.0)(!(version&gt;=2.15.0)))"</requirement> 
        
           <feature dependency="true">openhab.tp-xtext</feature> 
        
           <requirement>openhab.tp;filter:="(feature=jax-rs)"</requirement> 
        
           <feature dependency="true">openhab.tp-jax-rs</feature> 
        
           <requirement>openhab.tp;filter:="(feature=httpclient)"</requirement> 
        
           <feature dependency="true">openhab.tp-httpclient</feature>

openhab-bot · 2019-02-03T13:08:28Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/caldav-binding-to-read-holidays-calendar/66367/13

kaikreuzer · 2019-02-03T18:09:19Z

Thanks - hopefully it is fixed now.

bundles/org.openhab.core.ephemeris/.settings/org.eclipse.jdt.core.prefs

bundles/org.openhab.core.ephemeris/build.properties

...emeris/src/main/java/org/eclipse/smarthome/core/ephemeris/internal/EphemerisManagerImpl.java

features/karaf/openhab-core/src/main/feature/feature.xml

...pt/src/org/eclipse/smarthome/model/script/internal/engine/action/EphemerisActionService.java

maggu2810 · 2019-02-04T08:04:01Z

bundles/org.openhab.core.ephemeris/pom.xml

+      <artifactId>org.openhab.core.config.core</artifactId>
+      <version>${project.version}</version>
+    </dependency>
+    <dependency>


On my machine it is working (building the project after removing that lines).

Looking at the check of the first commit:

continuous-integration/travis-ci/pr: success

PR-openHAB-Core: failure

I assume you should check your Jenkins configuration.

features/karaf/openhab-core/src/main/feature/feature.xml

svendiedrichsen · 2019-02-11T20:53:50Z

@kaikreuzer I wrote the Jollyday library. If there is anything I can do to help please contact me.

meingraham · 2019-02-18T18:58:00Z

Is there an ETA on a beta version of the Ephemeris service? I'm happy to be an early tester.

bundles/org.openhab.core.ephemeris/NOTICE

maggu2810 · 2019-05-11T16:12:15Z

@kaikreuzer Do you plan to update this PR?

kaikreuzer · 2019-05-11T18:23:01Z

I had put in on hold as long as I didn't have a proper IDE. Will try to find time to revisit it.

@clinique As this code was written by you, feel free to help getting it merged by doing PRs against this branch :-)

Also-by: Gaël L'hopital <gael@lhopital.org> Signed-off-by: Kai Kreuzer <kai@openhab.org>

Signed-off-by: Kai Kreuzer <kai@openhab.org>

kaikreuzer · 2019-06-10T22:15:57Z

All, sorry for the delay. All comments should be addressed now.

maggu2810 · 2019-06-11T05:33:16Z

bundles/org.openhab.core.ephemeris/pom.xml

+      <artifactId>org.openhab.core.config.core</artifactId>
+      <version>${project.version}</version>
+    </dependency>
+    <dependency>


IMHO my comment is still valid and should be addressed.

...nhab.core.ephemeris/src/main/java/org/eclipse/smarthome/core/ephemeris/EphemerisManager.java

...emeris/src/main/java/org/eclipse/smarthome/core/ephemeris/internal/EphemerisManagerImpl.java

...pt/src/org/eclipse/smarthome/model/script/internal/engine/action/EphemerisActionService.java

features/karaf/openhab-tp/src/main/feature/feature.xml

Signed-off-by: Kai Kreuzer <kai@openhab.org>

kaikreuzer · 2019-06-11T06:23:27Z

Thanks, @maggu2810, I have addressed all your comments.

.../org.openhab.core.model.script/src/org/eclipse/smarthome/model/script/actions/Ephemeris.java

Signed-off-by: Kai Kreuzer <kai@openhab.org>

kaikreuzer · 2019-06-11T07:12:09Z

Seems I still got something wrong wrt to the feature definitions...

maggu2810 · 2019-06-11T07:24:23Z

features/karaf/openhab-core/src/main/feature/feature.xml

@@ -114,6 +114,16 @@
    <bundle>mvn:org.openhab.core.bundles/org.openhab.core.config.discovery.usbserial.linuxsysfs/${project.version}</bundle>
  </feature>

+  <feature name="openhab-core-ephemeris" version="${project.version}">


You miss the ephemeris bundle itself in this very specific feature

Good point. No idea how that got lost...

Signed-off-by: Kai Kreuzer <kai@openhab.org>

wborn · 2019-06-11T20:07:07Z

After building a local distro I now see the following exceptions:

22:01:50.121 [ERROR] [org.openhab.core.model.script        ] - FrameworkEvent ERROR - org.openhab.core.model.script
org.osgi.framework.ServiceException: Exception in org.apache.felix.scr.impl.manager.SingleComponentManager.getService()
	at org.eclipse.osgi.internal.serviceregistry.ServiceFactoryUse.factoryGetService(ServiceFactoryUse.java:222) ~[?:?]
	at org.eclipse.osgi.internal.serviceregistry.ServiceFactoryUse.getService(ServiceFactoryUse.java:111) ~[?:?]
	at org.eclipse.osgi.internal.serviceregistry.ServiceConsumer$2.getService(ServiceConsumer.java:45) ~[?:?]
	at org.eclipse.osgi.internal.serviceregistry.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:508) ~[?:?]
	at org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.getService(ServiceRegistry.java:461) ~[?:?]
	at org.eclipse.osgi.internal.framework.BundleContextImpl.getService(BundleContextImpl.java:624) ~[?:?]
	at com.eclipsesource.jaxrs.publisher.internal.ResourceTracker.addingService(ResourceTracker.java:39) ~[?:?]
	at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:941) ~[?:?]
	at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:870) ~[?:?]
	at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256) ~[?:?]
	at org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183) ~[?:?]
	at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:318) ~[?:?]
	at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:261) ~[?:?]
	at com.eclipsesource.jaxrs.publisher.internal.Activator.openAllServiceTracker(Activator.java:91) ~[?:?]
	at com.eclipsesource.jaxrs.publisher.internal.Activator.start(Activator.java:55) ~[?:?]
	at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:779) ~[?:?]
	at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:1) ~[?:?]
	at java.security.AccessController.doPrivileged(Native Method) ~[?:?]
	at org.eclipse.osgi.internal.framework.BundleContextImpl.startActivator(BundleContextImpl.java:772) ~[?:?]
	at org.eclipse.osgi.internal.framework.BundleContextImpl.start(BundleContextImpl.java:729) ~[?:?]
	at org.eclipse.osgi.internal.framework.EquinoxBundle.startWorker0(EquinoxBundle.java:933) ~[?:?]
	at org.eclipse.osgi.internal.framework.EquinoxBundle$EquinoxModule.startWorker(EquinoxBundle.java:309) ~[?:?]
	at org.eclipse.osgi.container.Module.doStart(Module.java:581) ~[?:?]
	at org.eclipse.osgi.container.Module.start(Module.java:449) ~[?:?]
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:383) ~[?:?]
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:402) ~[?:?]
	at org.apache.karaf.features.internal.service.BundleInstallSupportImpl.startBundle(BundleInstallSupportImpl.java:165) ~[?:?]
	at org.apache.karaf.features.internal.service.FeaturesServiceImpl.startBundle(FeaturesServiceImpl.java:1153) ~[?:?]
	at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:1036) ~[?:?]
	at org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1062) ~[?:?]
	at org.apache.karaf.features.internal.service.FeaturesServiceImpl.lambda$doProvisionInThread$13(FeaturesServiceImpl.java:998) ~[?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:?]
	at java.lang.Thread.run(Thread.java:748) ~[?:?]
Caused by: java.lang.NoClassDefFoundError: org/eclipse/smarthome/core/ephemeris/EphemerisManager
	at java.lang.Class.getDeclaredMethods0(Native Method) ~[?:?]
	at java.lang.Class.privateGetDeclaredMethods(Class.java:2701) ~[?:?]
	at java.lang.Class.getDeclaredMethods(Class.java:1975) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BindMethod.getServiceObjectAssignableMethod(BindMethod.java:469) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BindMethod.doFindMethod(BindMethod.java:180) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BaseMethod.findMethod(BaseMethod.java:173) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BaseMethod.access$400(BaseMethod.java:41) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BaseMethod$NotResolved.resolve(BaseMethod.java:602) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BaseMethod$NotResolved.methodExists(BaseMethod.java:626) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BaseMethod.methodExists(BaseMethod.java:528) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BindMethod.getServiceObject(BindMethod.java:659) ~[?:?]
	at org.apache.felix.scr.impl.manager.DependencyManager.getServiceObject(DependencyManager.java:2308) ~[?:?]
	at org.apache.felix.scr.impl.manager.DependencyManager$SingleStaticCustomizer.prebind(DependencyManager.java:1154) ~[?:?]
	at org.apache.felix.scr.impl.manager.DependencyManager.prebind(DependencyManager.java:1568) ~[?:?]
	at org.apache.felix.scr.impl.manager.AbstractComponentManager.collectDependencies(AbstractComponentManager.java:1029) ~[?:?]
	at org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:935) ~[?:?]
	at org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:900) ~[?:?]
	at org.eclipse.osgi.internal.serviceregistry.ServiceFactoryUse$1.run(ServiceFactoryUse.java:212) ~[?:?]
	at java.security.AccessController.doPrivileged(Native Method) ~[?:?]
	at org.eclipse.osgi.internal.serviceregistry.ServiceFactoryUse.factoryGetService(ServiceFactoryUse.java:210) ~[?:?]
	... 34 more
Caused by: java.lang.ClassNotFoundException: org.eclipse.smarthome.core.ephemeris.EphemerisManager cannot be found by org.openhab.core.model.script_2.5.0.201906111951
	at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:484) ~[?:?]
	at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:395) ~[?:?]
	at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:387) ~[?:?]
	at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:150) ~[?:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:?]
	at java.lang.Class.getDeclaredMethods0(Native Method) ~[?:?]
	at java.lang.Class.privateGetDeclaredMethods(Class.java:2701) ~[?:?]
	at java.lang.Class.getDeclaredMethods(Class.java:1975) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BindMethod.getServiceObjectAssignableMethod(BindMethod.java:469) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BindMethod.doFindMethod(BindMethod.java:180) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BaseMethod.findMethod(BaseMethod.java:173) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BaseMethod.access$400(BaseMethod.java:41) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BaseMethod$NotResolved.resolve(BaseMethod.java:602) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BaseMethod$NotResolved.methodExists(BaseMethod.java:626) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BaseMethod.methodExists(BaseMethod.java:528) ~[?:?]
	at org.apache.felix.scr.impl.inject.methods.BindMethod.getServiceObject(BindMethod.java:659) ~[?:?]
	at org.apache.felix.scr.impl.manager.DependencyManager.getServiceObject(DependencyManager.java:2308) ~[?:?]
	at org.apache.felix.scr.impl.manager.DependencyManager$SingleStaticCustomizer.prebind(DependencyManager.java:1154) ~[?:?]
	at org.apache.felix.scr.impl.manager.DependencyManager.prebind(DependencyManager.java:1568) ~[?:?]
	at org.apache.felix.scr.impl.manager.AbstractComponentManager.collectDependencies(AbstractComponentManager.java:1029) ~[?:?]
	at org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:935) ~[?:?]
	at org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:900) ~[?:?]
	at org.eclipse.osgi.internal.serviceregistry.ServiceFactoryUse$1.run(ServiceFactoryUse.java:212) ~[?:?]
	at java.security.AccessController.doPrivileged(Native Method) ~[?:?]
	at org.eclipse.osgi.internal.serviceregistry.ServiceFactoryUse.factoryGetService(ServiceFactoryUse.java:210) ~[?:?]
	... 34 more

maggu2810 · 2019-06-11T22:06:17Z

I did not realize the namesoace on review.
Why do we use org.eclipse.smarthome for code that is newly added to the repository?

maggu2810 · 2019-06-12T17:48:59Z

@kaikreuzer Can you comment?

kaikreuzer · 2019-06-12T19:46:16Z

Why do we use org.eclipse.smarthome for code that is newly added to the repository?

Because of #506 (comment): "Ported over from eclipse-archived/smarthome#6227". This was a contribution to ESH, which just wasn't merged on time.
I agree that we could have adapted the namespace, but I tried to keep it the original contribution that it was.
Ok for me to do a follow-up PR with an updated namespace, if you wish. Otherwise, we do it with an upcoming bulk rename for 3.x.

maggu2810 · 2019-06-12T20:25:18Z

We renamed the whole automation part that has already been part of ESH.
I don't understand for which part it is important and for which contribution it is optional.

kaikreuzer · 2019-06-12T20:28:02Z

For automation it was exceptionally important as this code was a new API that many bindings immediately wanted to use, so a lot of code was implemented using it.

openhab-bot · 2019-06-27T19:51:05Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/jython-logaction-not-working/77115/7

openhab-bot · 2019-07-01T23:23:23Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/preparation-for-2-5m2/75738/1

Also-by: Gaël L'hopital <gael@lhopital.org> Signed-off-by: Kai Kreuzer <kai@openhab.org> GitOrigin-RevId: d0dfbe3

kaikreuzer mentioned this pull request Feb 1, 2019

Rebuilding Ephemeris service after messing PR #5951 eclipse-archived/smarthome#6227

Closed

maggu2810 reviewed Feb 1, 2019

View reviewed changes

maggu2810 reviewed Feb 4, 2019

View reviewed changes

features/karaf/openhab-core/src/main/feature/feature.xml Show resolved Hide resolved

wborn added the new contribution label Mar 5, 2019

wborn reviewed Mar 6, 2019

View reviewed changes

bundles/org.openhab.core.ephemeris/NOTICE Outdated Show resolved Hide resolved

kaikreuzer added 4 commits June 11, 2019 00:10

Ephemeris service

18be784

Also-by: Gaël L'hopital <gael@lhopital.org> Signed-off-by: Kai Kreuzer <kai@openhab.org>

added dependency to bundle itself

2757dae

Signed-off-by: Kai Kreuzer <kai@openhab.org>

addressed review comments (but one)

b0db58e

Signed-off-by: Kai Kreuzer <kai@openhab.org>

added optional feature dependency

33ecfc1

Signed-off-by: Kai Kreuzer <kai@openhab.org>

kaikreuzer force-pushed the ephemeris branch from 9baeafc to 33ecfc1 Compare June 10, 2019 22:15

kaikreuzer added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Jun 10, 2019

kaikreuzer closed this Jun 10, 2019

kaikreuzer reopened this Jun 10, 2019

maggu2810 suggested changes Jun 11, 2019

View reviewed changes

kaikreuzer added 2 commits June 11, 2019 08:02

removed external dependency from bundle

95255f8

Signed-off-by: Kai Kreuzer <kai@openhab.org>

addressed review comments

841a527

Signed-off-by: Kai Kreuzer <kai@openhab.org>

maggu2810 approved these changes Jun 11, 2019

View reviewed changes

maggu2810 reviewed Jun 11, 2019

View reviewed changes

.../org.openhab.core.model.script/src/org/eclipse/smarthome/model/script/actions/Ephemeris.java Outdated Show resolved Hide resolved

removed outdated catch

460b69a

Signed-off-by: Kai Kreuzer <kai@openhab.org>

maggu2810 approved these changes Jun 11, 2019

View reviewed changes

maggu2810 reviewed Jun 11, 2019

View reviewed changes

added bundle to feature

1dbdadf

Signed-off-by: Kai Kreuzer <kai@openhab.org>

maggu2810 approved these changes Jun 11, 2019

View reviewed changes

maggu2810 merged commit d0dfbe3 into openhab:master Jun 11, 2019

kaikreuzer deleted the ephemeris branch June 11, 2019 09:01

clinique mentioned this pull request Jun 12, 2019

Ephemeris service generating errors #868

Closed

wborn added this to the 2.5 milestone Jul 30, 2019

wborn mentioned this pull request Aug 6, 2019

[ephemeris] Adopted configuration for Ephemeris service #919

Merged

cweitkamp added the enhancement An enhancement or new feature of the Core label Dec 3, 2019

cweitkamp changed the title ~~Ephemeris service~~ [ephemeris] Added Ephemeris service Dec 3, 2019

splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023

Ephemeris service (openhab#506)

688863e

Also-by: Gaël L'hopital <gael@lhopital.org> Signed-off-by: Kai Kreuzer <kai@openhab.org> GitOrigin-RevId: d0dfbe3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ephemeris] Added Ephemeris service #506

[ephemeris] Added Ephemeris service #506

kaikreuzer commented Feb 1, 2019

kaikreuzer commented Feb 1, 2019

maggu2810 left a comment

maggu2810 Feb 1, 2019

kaikreuzer Feb 1, 2019

maggu2810 Feb 4, 2019

maggu2810 Jun 11, 2019

kaikreuzer Jun 11, 2019

kaikreuzer commented Feb 1, 2019

maggu2810 commented Feb 1, 2019

openhab-bot commented Feb 3, 2019

kaikreuzer commented Feb 3, 2019

maggu2810 Feb 4, 2019

svendiedrichsen commented Feb 11, 2019 •

edited

Loading

meingraham commented Feb 18, 2019

maggu2810 commented May 11, 2019

kaikreuzer commented May 11, 2019

kaikreuzer commented Jun 10, 2019

maggu2810 Jun 11, 2019

kaikreuzer commented Jun 11, 2019

kaikreuzer commented Jun 11, 2019

maggu2810 Jun 11, 2019

kaikreuzer Jun 11, 2019

wborn commented Jun 11, 2019

maggu2810 commented Jun 11, 2019

maggu2810 commented Jun 12, 2019

kaikreuzer commented Jun 12, 2019

maggu2810 commented Jun 12, 2019

kaikreuzer commented Jun 12, 2019

openhab-bot commented Jun 27, 2019

openhab-bot commented Jul 1, 2019

[ephemeris] Added Ephemeris service #506

[ephemeris] Added Ephemeris service #506

Conversation

kaikreuzer commented Feb 1, 2019

kaikreuzer commented Feb 1, 2019

maggu2810 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaikreuzer commented Feb 1, 2019

maggu2810 commented Feb 1, 2019

openhab-bot commented Feb 3, 2019

kaikreuzer commented Feb 3, 2019

Choose a reason for hiding this comment

svendiedrichsen commented Feb 11, 2019 • edited Loading

meingraham commented Feb 18, 2019

maggu2810 commented May 11, 2019

kaikreuzer commented May 11, 2019

kaikreuzer commented Jun 10, 2019

Choose a reason for hiding this comment

kaikreuzer commented Jun 11, 2019

kaikreuzer commented Jun 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wborn commented Jun 11, 2019

maggu2810 commented Jun 11, 2019

maggu2810 commented Jun 12, 2019

kaikreuzer commented Jun 12, 2019

maggu2810 commented Jun 12, 2019

kaikreuzer commented Jun 12, 2019

openhab-bot commented Jun 27, 2019

openhab-bot commented Jul 1, 2019

svendiedrichsen commented Feb 11, 2019 •

edited

Loading