Start.sh script can blow up installation

[splatch]

Karaf bin script allows to pass arguments such clean or debug. These arguments passed to start.sh are passed to karaf script. Calling ./start.sh clean causes removal of entire userdata directory and doesn't allow to launch runtine any more:

Launching the openHAB runtime...
karaf: KARAF_BASE is not valid: ~/openhab-distro/distributions/openhab-online/target/openhab-online-2.0.0-SNAPSHOT/userdata

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[maggu2810]

That is already known.
https://github.com/openhab/openhab2-addons/pull/571
There is also another discussion (don't find them ATM) if we should mask the clean in start.sh.
The decision that has been made is that as long as the clean option is not documented, it does not need to be masked.

[maggu2810]

Found it, see comments here: #27

[kaikreuzer]

Nonetheless, I think this is an issue that we have to discuss, see also https://community.openhab.org/t/what-is-effect-of-dosgi-clean-in-karaf/6320.

OH1 does a clean on every startup, so for users it is always clear, what configuration their system has (the one defined in their config files and with exactly the add-ons that they have in the addons folder).
Not cleaning in OH2 and having alternative configuration mechanisms (through the Paper UI, through the shell) confuses many users and it is hard to understand, which configuration/setup is actually active. An example is that people test addons by putting them in the addons folder and when replacing it there by a newer version, the old bundle is still deployed and active, what nobody expects.

I am not clear on what might be the best strategy for addressing these problems and for making it easy and understandable for the (not OSGi/Karaf-trained) average openHAB user.
Suggestions are welcome!