-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sliders Start Moving the Wrong Slider Sometimes #646
Comments
@NickWaterton: This is concerning. The videos you provide unfortunately are not visible to me with Safari. I tried with Safari on MacOS and with GitHub app on iOS. Is there an issue on GitHub? Can you provide server logs to analyse this in more detail? |
@agsochi @NickWaterton please provide additional information: OH version, example sitemap to reproduce the issue, etc. |
@weakfl
If i turn off "real-time sliders" in settings - sliders work ok |
@agsochi I tried to reproduce this but it's working as expected. I'm not sure if this isn't caused by your config, rules, etc. |
I removed rules files, same behavior |
I found what it is. OK
NOT OK
:) |
I had something similar happen on my As mentioned above this only started happened with some of the recent test-flight versions (the build including the Main UI had the problem but not sure if the previous test-flight did, I didn't think so though). Excerpt from the sitemap file, sitemap file size is
Screencap displaying the problem RPReplay_Final1644149075.mp4The Note that the As you can see from Main UI each of the items seems pretty standard to me. |
@NickWaterton are you using groups for your items? Please provide the relevant *.items file(s) as well. |
Yes I am. Here is the relevant section of my .items file:
There is a rule triggered by |
Could be related to an issue on reusable cells. @weakfl: try to have more than a screenful of cells in your test sitemap Maybe a bug in merge of storyboard files |
I could reproduce the issue in demo mode on simulator: Main Menu -> Widget Overview -> PERCENT-BASED WIDGETS, wiggle around when real-time sliders are selected. I haven't found the fix yet |
@weakfl is there a structural issue here? Would we need to have a view model that holds the information and configures the cells? If so, why did it work up to now? |
@timbms I doubt this has ever worked as intended.
Could be. Since the widget is not captured it might easily have changed when the closure executes, sending the value to the wrong widget.
Of course that would be a better approach. The view shouldn't store the widget at all imho. Unrelated rant: we should look at raising the deployment target to iOS 13. Think SwiftUI, MVVM, Concurrency, Combine, etc... |
I use to use an iPhone 6 which meant no iOS 13. If you do consider upping the target os, consider what important features and fixes you want to bring in before it happens so that those with older iDevices don't miss out! |
@Cossey we would definitely try to have a stable version that includes important features and bug fixes before we increase the deployment target. But at some point we'll have to make a cut to be able to use new frameworks that facilitate development. After all the iPhone 6 has been released more than 7 years ago. |
I couldn't agree more. At some time we need to make a clear cut. |
Yes, this is a design flaw. To be addressed swiftly. |
FullSizeRender.MOVI‘m having the same issue. In the video I’m moving „Dimmer rechts“ and the other sliders start moving by the themselves after the update. In addition the names of the sliders keep switching by themselves. |
@a-umar : please try to switch real-time sliders off. This could lessen the problem. |
@weakfl any idea for a quick fix ? |
@timbms I'll try to look into this at the weekend… |
With the new app update the issue is still there. Any updates on this issue? It’s pretty unusable for me right now :( |
Same Problem here, i activated and deactivated lifetime-sliders ….it seems to work……but after restarting the app, I done it again…..so every restart : lifetime sliders Active=Deactive…….stay in touch |
Yeah, same here. Frustrating when turning down the living rooms light, the kids room light up... |
@timbms Have you any updates on this issues? |
…Cells for the time being. (call of sliderDidChange in sliderValueChanged would cause issues even without Throttler)
@weakfl : I deactivated real-time sliders to get over the problem - at least I was able to interact with the demo site. Maybe you can release on TestFlight for others to test. |
Issue is still there in 2.4.56. If i replace function body of displayWidget in SlideUITableViewCell so that there is only
in it (nothing else) and then changing the slider value. While changing the value and after the change some crazy reordering within the sliders occure. I try to debug but i'm not so deep into ios development. Maybe some of the developers of the ios app can have a look. |
dequeueReusableCell of an in-use slider will cause the reused slider to appear on different position. Fix will only update cells which are currently not in use.
dequeueReusableCell of an in-use slider will cause the reused slider to appear on different position. Fix will only update cells which are currently not in use. Signed-off-by: Moellide <moelli.de@googlemail.com>
dequeueReusableCell of an in-use slider will cause the reused slider to appear on different position. Fix will only update cells which are currently not in use. Signed-off-by: Moellide <moelli.de@googlemail.com>
This slider issue is really anoying, Hope this can get merged soon. If there is anything i can test or do to speed up to process, let me know. |
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
This is still present in latest app on appstore. Also this comment on an PR suggests this issue should not be closed yet: #715 (comment) @digitaldan can we reopen? |
Is this present in the test flight builds ? I was preparing a release this weekend , but it's been a while since we have pushed our test flight build to the App Store |
Original bug with wrong slider movement is fixed with the test flight build, but not with official app store version. Test fligt version has some problems when moving the slider for a longer period of time (>5 seconds, holding it in the drag-state) and then releasing it. Sometimes it occurrs, that slider value is not accepted/gets send. The slider jumps directly to the original value before the drag started. Does only occure if more then one slider is on the page. It's difficult to set the exact value because you don't have much time. |
Ah that explains why I thought this was simply not fixed correctly, as this is been going on for months. I'll await the update then. Any incremental update is better than the current state TBH, it's really unusable for my wife currently. |
@digitaldan did the update every go through? |
still problem continues with the latest app. version 2.4.56 |
Describe the bug
On the current version (as of 3 days ago, 31st Jan 2022), if you try to move a slider, the slider above it or below it may move instead. The sliders jump about as you slide your finger from left to right. Sometimes it's not the slider immediately below or above, but one 2-3 sliders above or below. This is not a "fat finger issue".
This has been working properly for years, but now doesn't.
To Reproduce
Steps to reproduce the behavior:
Screenshots
In this video I am only adjusting "Max Global Brightness", which is a dummy slider with no channel. The top four sliders are supposed to be updating with new values.
This is the 'flicking" technique, to adjust the sliders back to where they were.
If, on the above screenshot you try to adjust "Max Global Brightness", then quite often "Max Brightness" or ""Speed Control", or "Saturation" will change instead. This happens when you select and drag. If you "flick" the slider with the tip of your finger, you can get it to move a bit. This is the only way I have been reliably able to get sliders to move individually.
Please note this does not happen every time. Sometimes it works fine, others I can't move a slider without others all starting to move.
I have been using this screen for 4 years with no issues. The problem does not happen when using the basic UI either.
App (please complete the following information):
Smartphone (please complete the following information):
openHAB (please complete the following information):
The text was updated successfully, but these errors were encountered: