Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Vue from 2.6.12 to 2.7.16 #2489

Merged
merged 2 commits into from Mar 21, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Mar 21, 2024

Also upgrade unit test dependencies and unit test and and ESLint config

See https://v2.vuejs.org/v2/guide/migration-vue-2-7 for Vue migration guide.
See https://github.com/vuejs/vue-test-utils/ and https://github.com/vuejs/vue-jest for unit tests.
See https://github.com/vuejs/eslint-plugin-vue/releases/tag/v9.0.0 for ESLint rule changes.

@florian-h05 florian-h05 requested a review from a team as a code owner March 21, 2024 17:29
Copy link

relativeci bot commented Mar 21, 2024

Job #1827: Bundle Size — 10.55MiB (-0.02%).

068b411(current) vs 577d6ed main#1825(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Regression 2 regressions Improvement 1 improvement
                 Current
Job #1827
     Baseline
Job #1825
Regression  Initial JS 1.86MiB(+0.86%) 1.85MiB
No change  Initial CSS 607.88KiB 607.88KiB
Change  Cache Invalidation 24.31% 21.05%
No change  Chunks 223 223
No change  Assets 246 246
Change  Modules 2857(-0.03%) 2858
No change  Duplicate Modules 141 141
Regression  Duplicate Code 1.73%(+1.17%) 1.71%
Improvement  Packages 94(-1.05%) 95
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #1827
     Baseline
Job #1825
Improvement  JS 8.74MiB (-0.02%) 8.74MiB
Not changed  CSS 890.04KiB 890.04KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1827 reportView florian-h05:upgrade-vue-v27 branch activityView project dashboard

See https://github.com/vuejs/eslint-plugin-vue/releases/tag/v9.0.0 for ESLint rule changes.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Mar 21, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 21, 2024
@florian-h05 florian-h05 merged commit 70b2df2 into openhab:main Mar 21, 2024
6 checks passed
@florian-h05 florian-h05 deleted the upgrade-vue-v27 branch March 21, 2024 17:59
@florian-h05 florian-h05 added the dependencies Pull requests that update a dependency file label Mar 26, 2024
florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Apr 20, 2024
Fixes openhab#2530.
Regression from openhab#2489.

I wasn't able to identify the root cause, but this seems to solve the problem.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05 added a commit that referenced this pull request Apr 20, 2024
Fixes #2530.
Regression from #2489.

I wasn't able to identify the root cause, but this seems to solve the problem.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant