Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSE Item State Tracking: Avoid requesting __ob__ and __v_isRef #2540

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

florian-h05
Copy link
Contributor

Fixes #2530.
Regression from #2489.

I wasn't able to identify the root cause, but this seems to solve the problem.

Fixes openhab#2530.
Regression from openhab#2489.

I wasn't able to identify the root cause, but this seems to solve the problem.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Copy link

relativeci bot commented Apr 20, 2024

Job #1899: Bundle Size — 10.56MiB (~-0.01%).

571b7dc(current) vs bb66514 main#1898(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
Job #1899
     Baseline
Job #1898
Improvement  Initial JS 1.86MiB(~-0.01%) 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
Change  Cache Invalidation 17.63% 18.3%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2861 2861
No change  Duplicate Modules 141 141
No change  Duplicate Code 1.73% 1.73%
No change  Packages 95 95
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #1899
     Baseline
Job #1898
Improvement  JS 8.75MiB (~-0.01%) 8.75MiB
Not changed  CSS 890.07KiB 890.07KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1899 reportView florian-h05:fix-2530 branch activityView project dashboard

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI regression labels Apr 20, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Apr 20, 2024
@florian-h05 florian-h05 merged commit aadeb38 into openhab:main Apr 20, 2024
6 checks passed
@florian-h05 florian-h05 deleted the fix-2530 branch April 20, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI regression
Projects
None yet
1 participant