Fritzbox Binding log message #881 #1482
Conversation
Update from original
Telnet connection is now only opened if a password is set and if there is an item configured which uses the telnet connect on the standard port.
| @@ -145,7 +145,8 @@ public void deactivate() { | |||
| @Override | |||
| public void internalReceiveCommand(String itemName, Command command) { | |||
|
|
|||
| if (password != null) { | |||
| if (password != null && !password.isEmpty()) { | |||
| logger.warn("Fritzbox password: "+password); | |||
There was a problem hiding this comment.
passwords should usually better not appear in log files - and it also makes no sense to have it as a warning.
I'd suggest to either remove it or reduce to DEBUG level.
There was a problem hiding this comment.
Oh man. Forgot to remove the logging. Sorry.
|
Thanks! Could you possibly also run the code formatter over this class? There are a couple of spaces missing etc. to make the code conform to the formatting guidelines. |
|
Is there a special openhab formating profile for cleanup in eclipse ? |
|
Found the formatting hint in the wiki :-) |
|
openhab » openhab #1255 SUCCESS |
|
Hi @mod42 i will merge this PR as soon as the password logging has been removed. Best, Thomas E.-E. |
|
openhab » openhab #1338 SUCCESS |
Fritzbox Binding log message #881
|
thanks @mod42 |
…penhab#1466 (openhab#1482) Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Telnet connection is now only opened if a password is set and if there
is an item configured which uses the telnet connect on the standard
port. Annoying warning message is not sent anymore.