Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop fixed path in favor of relative when calling binaries #625

Closed
1 of 2 tasks
EliasGabrielsson opened this issue Aug 4, 2019 · 1 comment · Fixed by #1055
Closed
1 of 2 tasks

Drop fixed path in favor of relative when calling binaries #625

EliasGabrielsson opened this issue Aug 4, 2019 · 1 comment · Fixed by #1055
Assignees
@mstormi @ecdye
Labels
enhancement New feature or request nice to have Makes life easier
Milestone
Refinement and Re...

Comments

@EliasGabrielsson
Copy link
Contributor

EliasGabrielsson commented Aug 4, 2019 •
edited by mstormi

In order to get some more headroom for folder changes should the scripts in what extent is possible use relative calling on binaries. i.e. git in favor of /local/bin/git.

  • Update CONTRIBUTE.md with coding style
  • Review all files in the whole repository
@mstormi
Copy link
Contributor

mstormi commented Aug 7, 2019

For proper understanding: you mean in DISfavor of using the whole path, i.e. just use "git" in our scripts - correct ?

@mstormi mstormi changed the title Drop fixed path in favor for relative when calling binaries Drop fixed path in favor of relative when calling binaries Apr 16, 2020
@mstormi mstormi self-assigned this Apr 16, 2020
@mstormi mstormi mentioned this issue Jun 16, 2020
Merged
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
685adda 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
f5f45a4 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
7952b91 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
beb1d02 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
214470c 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
f106802 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
e2c115e 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
26cfa6f 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
619ba36 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
9eb4358 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
16719bd 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
510e973 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
12535f9 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
847d516 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 16, 2020
@ecdye
Documentation and coding guidelines update
d1173dd 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 17, 2020
@ecdye
Documentation and coding guidelines update
1eb5e35 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 17, 2020
@ecdye
Documentation and coding guidelines update
7135167 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 17, 2020
@ecdye
Documentation and coding guidelines update
eaf4e46 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 17, 2020
@ecdye
Documentation and coding guidelines update
ddcacba 
Also this includes further changes in terms of the Standarization and
Rewrite.

Fixes openhab#949
Related openhab#519 openhab#625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
mstormi pushed a commit that referenced this issue Jun 17, 2020
@ecdye
Begin Standardization and Rewrite (#938)
e2a5290 
* Begin Standardization and Rewrite

Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes #936
Related #937 #949

Signed-off-by: Ethan Dye <mrtops03@gmail.com>

* Documentation and coding guidelines update

Also this includes further changes in terms of the Standardization and
Rewrite.

Fixes #949
Related #519 #625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
@ecdye ecdye added enhancement New feature or request nice to have Makes life easier labels Jun 28, 2020
@ecdye ecdye self-assigned this Jun 28, 2020
@mstormi mstormi mentioned this issue Jul 27, 2020
Merged
@ecdye ecdye mentioned this issue Aug 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mstormi mstormi

@ecdye ecdye

Labels
enhancement New feature or request nice to have Makes life easier
Projects
None yet
Milestone
Refinement and Refocus
Development

Successfully merging a pull request may close this issue.

Finish Standardization and Rewrite ecdye/openhabian
3 participants
@EliasGabrielsson @mstormi @ecdye