Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repo key downloads #936

Closed
mstormi opened this issue May 31, 2020 · 4 comments · Fixed by #938
Closed

Fix repo key downloads #936

mstormi opened this issue May 31, 2020 · 4 comments · Fixed by #938
Labels
enhancement New feature or request

Comments

@mstormi
Copy link
Contributor

mstormi commented May 31, 2020 •
edited

Several instances like
cond_redirect wget -O - http://homegear.eu/packages/Release.key | apt-key add -

can fail if repo file or repo are broken
should be rewritten like this

wget --no-check-certificate -qO "$RepoKey" 'https://bintray.com/user/downloadSubjectPublicKey?username=openhab'
cond_redirect apt-key add "$RepoKey"
rm -f "$RepoKey"
@ecdye
Copy link
Contributor

ecdye commented May 31, 2020

This is part of what I would consider a bigger issue that involves rewriting most if not all of the functions for safer and more consistent execution and status reporting.

I am going to start re-writing many of the functions and will include this as part of the process.

@ecdye ecdye mentioned this issue Jun 1, 2020
Closed
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 1, 2020
@ecdye
Begin Standardization and Re-Write
325a2cb 
Fixes openhab#936 openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
@ecdye ecdye mentioned this issue Jun 1, 2020
Merged
@holgerfriedrich
Copy link
Member

holgerfriedrich commented Jun 1, 2020 •
edited

Consider using a helper function to implement this. mktemp could also be your friend.

@holgerfriedrich holgerfriedrich added the enhancement New feature or request label Jun 1, 2020
@ecdye
Copy link
Contributor

ecdye commented Jun 1, 2020

Yep.

ecdye added a commit to ecdye/openhabian that referenced this issue Jun 10, 2020
@ecdye
Begin Standardization and Rewrite
f76a541 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 11, 2020
@ecdye
Begin Standardization and Rewrite
07cf9e3 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 11, 2020
@ecdye
Begin Standardization and Rewrite
a0265e4 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 11, 2020
@ecdye
Begin Standardization and Rewrite
8fdbcb8 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 12, 2020
@ecdye
Begin Standardization and Rewrite
2a09926 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 12, 2020
@ecdye
Begin Standardization and Rewrite
343f598 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 12, 2020
@ecdye
Begin Standardization and Rewrite
b012fa4 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 12, 2020
@ecdye
Begin Standardization and Rewrite
68915e8 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 12, 2020
@ecdye
Begin Standardization and Rewrite
a1e381a 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 12, 2020
@ecdye
Begin Standardization and Rewrite
0cb14e8 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 12, 2020
@ecdye
Begin Standardization and Rewrite
41038a8 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 12, 2020
@ecdye
Begin Standardization and Rewrite
dbe447d 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 12, 2020
@ecdye
Begin Standardization and Rewrite
3bdf568 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 12, 2020
@ecdye
Begin Standardization and Rewrite
6001385 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 13, 2020
@ecdye
Begin Standardization and Rewrite
1c44608 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 13, 2020
@ecdye
Begin Standardization and Rewrite
bb33a20 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 13, 2020
@ecdye
Begin Standardization and Rewrite
8f4260f 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 14, 2020
@ecdye
Begin Standardization and Rewrite
470df5b 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 14, 2020
@ecdye
Begin Standardization and Rewrite
b3d80d6 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 14, 2020
@ecdye
Begin Standardization and Rewrite
0a69048 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 14, 2020
@ecdye
Begin Standardization and Rewrite
683960f 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 14, 2020
@ecdye
Begin Standardization and Rewrite
089d32b 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937 openhab#949

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 14, 2020
@ecdye
Begin Standardization and Rewrite
6bdc827 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937 openhab#949

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 14, 2020
@ecdye
Begin Standardization and Rewrite
4ed3e6a 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937 openhab#949

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 14, 2020
@ecdye
Begin Standardization and Rewrite
e2127d4 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937 openhab#949

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 14, 2020
@ecdye
Begin Standardization and Rewrite
1f85cb0 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937 openhab#949

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 14, 2020
@ecdye
Begin Standardization and Rewrite
8297dea 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937 openhab#949

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 15, 2020
@ecdye
Begin Standardization and Rewrite
52873db 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937 openhab#949

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 15, 2020
@ecdye
Begin Standardization and Rewrite
af1bd63 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937 openhab#949

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 15, 2020
@ecdye
Begin Standardization and Rewrite
ed34939 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937 openhab#949

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 15, 2020
@ecdye
Begin Standardization and Rewrite
3372a8e 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937 openhab#949

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
ecdye added a commit to ecdye/openhabian that referenced this issue Jun 15, 2020
@ecdye
Begin Standardization and Rewrite
17a8d79 
Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes openhab#936
Related openhab#937 openhab#949

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
mstormi pushed a commit that referenced this issue Jun 17, 2020
@ecdye
Begin Standardization and Rewrite (#938)
e2a5290 
* Begin Standardization and Rewrite

Begins a rewrite of the openHABian core code to make it overall safer
and more verbose in failure. Additionally this helps to standardize the
coding format.

This contains major a major rewrite of 'packages.bash',
'nodejs-apps.bash', and other minor fixes in other files as well. This
also contains the proper testing functions using BATS for the rewritten
code.

Fixes #936
Related #937 #949

Signed-off-by: Ethan Dye <mrtops03@gmail.com>

* Documentation and coding guidelines update

Also this includes further changes in terms of the Standardization and
Rewrite.

Fixes #949
Related #519 #625

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
@DjSni
Copy link

DjSni commented Sep 21, 2021 •
edited

Hi,

it seems Bintray is deprecated. Openhab Update dont work.

Bintray has been deprecated,
but never fear!
The JFrog Platform offers many solutions to distribute your software internally or externally. Read more on this page about JFrog Distribution, or new, exciting technologies like Federated Repositories and the world’s first Private Distribution Network.

@DjSni DjSni mentioned this issue Sep 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Begin Standardization and Rewrite ecdye/openhabian
4 participants
@holgerfriedrich @mstormi @ecdye @DjSni