Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "landing.html" to "index.html" #1447

Closed
paulproteus opened this issue Oct 18, 2014 · 4 comments
Closed

Rename "landing.html" to "index.html" #1447

paulproteus opened this issue Oct 18, 2014 · 4 comments

Comments

@paulproteus
Copy link
Contributor

Right now, the template file that generates the front page of the site is called "landing.html". That's confusing! (It's in the mysite/base/templates/base directory; see also this listing, https://github.com/openhatch/oh-mainline/tree/master/mysite/base/templates/base )

It'd be great if we could move it to "index.html", and make sure the front page still loads.

To do this, you probably will want to run the code on your own machine, and use the "git mv" command.

It has a friend, "landing_page_for_contributors_tab-deprecated.html". I think that file can be deleted, since the following git grep command seems to come up empty:

$ git grep landing_page_for_contributors
$

It'd be cool if we could git rm that file, too.

I'd love to see a pull request from a new contributor on this! It would be great to see this change and also any other ones that help make the code easier for new people.

@TheOneTrueCDC
Copy link
Contributor

Hello! I'm a new contributor and I would like to work on this one. (cmdecesare on IRC)

@paulproteus
Copy link
Contributor Author

@cmdecesare that is great! Let us know how we can help, or when you have a pull request available for review!

@TheOneTrueCDC
Copy link
Contributor

#1451

paulproteus added a commit that referenced this issue Oct 19, 2014
#1447 | Rename "landing.html" to "index.html"
@ehashman
Copy link
Member

Merged so I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants