-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encapsulate Atlas specific API and types #30
Comments
I've worked towards this direction today and made sure oh-distro compiles without access to private externals. To this end, dependent modules are automatically turned off so that I am currently still running tests on it before opening a PR. It does not include yet, however, the separation of LCM types and a cleaner refactoring. [Edited to make clearer] |
[If you're reading from email, please disregard my earlier comment - it is updated online on GitHub; apologies for the extra email noise] |
The list of issues from that branch is useful. Judging from it, only a small number of issues needs be resolved. Lets fix the Atlas dependency first. |
This wasn't fully complete as when the Atlas was used the control directory was dependent on atlas_collections, so had to be reverted. will explore again in future |
I intend to gather up all Atlas specific code into a single place such that:
The steps:
Then during Valkyrie development, we will avoid the intermingling of our software and the manufacturer's API and proprietary files.
The text was updated successfully, but these errors were encountered: