Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVA6: Infrastructure improvements #1846

Merged
merged 1 commit into from May 9, 2023

Conversation

MarioOpenHWGroup
Copy link
Contributor

Some improvements in the current infrastructure:

  • Auto detect CV_SW_PREFIX if not set.
  • Set RISCV_GCC and RISCV_OBJCOPY if not set.
  • Avoid return statements when fatal errors.
  • Detection of the tohost addr now has more compatibility across systems.
  • Other improvements.

cva6/regress/install-cva6.sh Outdated Show resolved Hide resolved
cva6/regress/install-cva6.sh Outdated Show resolved Hide resolved
cva6/regress/install-verilator.sh Outdated Show resolved Hide resolved
cva6/regress/install-verilator.sh Outdated Show resolved Hide resolved
cva6/regress/install-cva6.sh Show resolved Hide resolved
@MarioOpenHWGroup
Copy link
Contributor Author

@cathales if you could take another look it would be great 😄

cva6/regress/install-verilator.sh Outdated Show resolved Hide resolved
cva6/regress/install-cva6.sh Outdated Show resolved Hide resolved
cva6/regress/install-cva6.sh Outdated Show resolved Hide resolved
@MarioOpenHWGroup MarioOpenHWGroup force-pushed the cva6/dev branch 2 times, most recently from dfcd15b to 1657b98 Compare May 3, 2023 12:58
@MikeOpenHWGroup
Copy link
Member

Hey @MarioOpenHWGroup and @cathales, there are multiple "conversations" in this PR (which is a good thing). I believe some of them are now fixed, but it is hard to tell. Please use the "Resolve conversation" button to close discussions that are resolved. Thanks.

@MarioOpenHWGroup
Copy link
Contributor Author

Hey @MarioOpenHWGroup and @cathales, there are multiple "conversations" in this PR (which is a good thing). I believe some of them are now fixed, but it is hard to tell. Please use the "Resolve conversation" button to close discussions that are resolved. Thanks.

For sure, I have resolved all the issues in the thread 👍

@MarioOpenHWGroup
Copy link
Contributor Author

@cathales a final revision would be appreciated 😃

@cathales
Copy link
Contributor

cathales commented May 9, 2023

@MikeOpenHWGroup I wanted to mark conversations as resolved but I am not allowed to do so.

PR LGTM, I think it would be great if @ASintzoff could have a look too, as he is one of the original authors.

@MikeOpenHWGroup
Copy link
Member

@MikeOpenHWGroup I wanted to mark conversations as resolved but I am not allowed to do so.

Yes, this is a strange GitHub feature: You can resolve a conversation in a pull request if you opened the pull request or if you have write access to the repository where the pull request was opened. In this context, "write access" is a someone who can approve a pull-request (a Committer). I think this is broken.

@ASintzoff
Copy link
Contributor

LGTM

@MikeOpenHWGroup MikeOpenHWGroup merged commit 64e9e6a into openhwgroup:cva6/dev May 9, 2023
1 check passed
MarioOpenHWGroup added a commit to MarioOpenHWGroup/core-v-verif that referenced this pull request May 10, 2023
…6/dev"

This reverts commit 64e9e6a, reversing
changes made to 1eac965.
JeanRochCoulon added a commit that referenced this pull request May 10, 2023
LeeHoff pushed a commit to LeeHoff/core-v-verif that referenced this pull request Oct 10, 2023
…6/dev"

This reverts commit 64e9e6a, reversing
changes made to 1eac965.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants