New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVA6: Infrastructure improvements #1846
CVA6: Infrastructure improvements #1846
Conversation
@cathales if you could take another look it would be great 😄 |
dfcd15b
to
1657b98
Compare
Hey @MarioOpenHWGroup and @cathales, there are multiple "conversations" in this PR (which is a good thing). I believe some of them are now fixed, but it is hard to tell. Please use the "Resolve conversation" button to close discussions that are resolved. Thanks. |
For sure, I have resolved all the issues in the thread 👍 |
@cathales a final revision would be appreciated 😃 |
@MikeOpenHWGroup I wanted to mark conversations as resolved but I am not allowed to do so. PR LGTM, I think it would be great if @ASintzoff could have a look too, as he is one of the original authors. |
Yes, this is a strange GitHub feature: |
LGTM |
Some improvements in the current infrastructure:
CV_SW_PREFIX
if not set.RISCV_GCC
andRISCV_OBJCOPY
if not set.tohost
addr now has more compatibility across systems.