Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference model #2432

Merged
merged 69 commits into from
Jun 21, 2024
Merged

Conversation

torjeikenes
Copy link

This draft PR brings in some of my work implementing a reference model with the goal of verifying asynchronous events. The RM contains a core-specific pipeline shell, built around a core-independent ISS. The ISS is currently Spike from vendor/riscv/, with modifications done on another branch from master. This PR is therefore not currently functional and depends on #2427 before both branches can be merged. As discussed with @silabs-robin, I am submitting this PS as a draft in order to get feedback and track what changes need to be made.

mk/uvmt/vsim.mk Outdated Show resolved Hide resolved
Copy link
Contributor

@silabs-robin silabs-robin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for the PR.
I have added comments for some of my immediate thoughts.

cv32e40s/tb/uvmt/reference_model.flist Outdated Show resolved Hide resolved
lib/uvm_agents/uvma_rvfi/uvma_rvfi_tdefs.sv Outdated Show resolved Hide resolved
mk/uvmt/uvmt.mk Outdated Show resolved Hide resolved
cv32e40s/tb/uvmt/uvmt_cv32e40s_reference_model_wrap.sv Outdated Show resolved Hide resolved
cv32e40s/tb/uvmt/uvmt_cv32e40s_reference_model_wrap.sv Outdated Show resolved Hide resolved
mk/uvmt/vsim.mk Outdated Show resolved Hide resolved
lib/reference_model/pipeline_shell.sv Outdated Show resolved Hide resolved
@silabs-robin silabs-robin marked this pull request as ready for review May 21, 2024 06:56
@silabs-robin silabs-robin changed the title [WIP] Reference model Reference model Jun 3, 2024
Copy link
Contributor

@silabs-robin silabs-robin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on:

  • All feedback resolved.
  • ci_check passes (how we typically run it with xrun).

@silabs-robin silabs-robin merged commit eda6222 into openhwgroup:cv32e40s/release Jun 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants