Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Riscv-dv to latest hash #509

Merged

Conversation

silabs-hfegran
Copy link
Contributor

@silabs-hfegran silabs-hfegran commented Mar 8, 2021

Summary of changes:

    - Removed jump to init_machine_mode (function location inlined
      by Google, no longer needed).

    - Reverted previous mret->ret change to init_machine_mode
      generator function to avoid an infinite loop.

    - Changed setup_mmode_reg to not enable MIE bit.
      This is instead done by mret at the end of code section
      by copying MPIE->MIE. (cf. riscv priv. spec.)
      This prevents an infinite loop if an interrupt request is
      present prior to init_machine_mode completion.

    - Updated common interrupt handler jump for increased robustness
      with large programs. (Ports over change from RISCV-DV
      upstream).

    - Added empty custom csr definitions for compatibility with
      latest Riscv-dv.

Signed-off-by: Henrik Fegran Henrik.Fegran@silabs.com

Summary of changes:
        - Removed jump to init_machine_mode (function location inlined
          by Google, no longer needed).

        - Reverted previous mret->ret change to init_machine_mode
          generator function to avoid an infinite loop.

        - Changed setup_mmode_reg to not enable MIE bit.
          This is instead done by mret at the end of code section
          by copying MPIE->MIE. (cf. riscv priv. spec.)
          This prevents an infinite loop if an interrupt request is
          present prior to init_machine_mode completion.

        - Updated common interrupt handler jump for increased robustness
          with large programs. (Ports over change from RISCV-DV
          upstream).

        - Added empty custom csr definitions for compatibility with
          latest Riscv-dv.

Signed-off-by: Henrik Fegran <Henrik.Fegran@silabs.com>
@@ -21,7 +21,7 @@ CV_CORE_TAG ?= cv32e40p_v1.0.0

RISCVDV_REPO ?= https://github.com/google/riscv-dv
RISCVDV_BRANCH ?= master
RISCVDV_HASH ?= 10fd4fa8b7d0808732ecf656c213866cae37045a
RISCVDV_HASH ?= 0b625258549e733082c12e5dc749f05aefb07d5a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silabs-halfdan, just FYI, you can use the most significant seven hex-digits when referencing a git hash. So this could be RISCVDV_HASH ?= 0b62525. (I learned this several weeks after generating the previous version of this Makefile.) The full hash is only required in the event of a collision.

@MikeOpenHWGroup MikeOpenHWGroup merged commit 0508ed9 into openhwgroup:master Mar 8, 2021
@silabs-hfegran silabs-hfegran deleted the riscv_latest_hash_i496 branch October 28, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants