add CV_CORE_PATH for optionally having rtl repo dir symlinked locally #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Pedersen <Robin.Pedersen@silabs.com>
silabs-robin
commented
Mar 29, 2021
| @@ -76,22 +76,26 @@ $(error Must define a COMPLIANCE_REPO to use the common makefile) | |||
| endif | |||
There was a problem hiding this comment.
This diff of Common.mk is a bit difficult to read because diff gets confused by the similarity of the lines.
It is easier read by opening the entire file.
MikeOpenHWGroup
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to point a core directory in
core-v-coresto a local directory via symlink. This is instead of cloning.The benefit is that one doesn't have to be afraid of some
make cleanor other scripts accidentally wiping the core directory.Hence one can safely work on a core's RTL and run ci_check, clean-build core-v-verif, etc.
(This is something we had locally, intermediately before the "multi-design" core-v-verif repo was ready. I am merely porting it over to the github repo now.)