Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .readthedocs.yaml #857

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Update .readthedocs.yaml #857

merged 1 commit into from
Aug 30, 2023

Conversation

MikeOpenHWGroup
Copy link
Member

Explicit build.os is now required by RTD.

@MikeOpenHWGroup
Update .readthedocs.yaml
da5bf7c 
Explicit build.os is now required by RTD.
@MikeOpenHWGroup MikeOpenHWGroup added the Component:Doc For issues in the Documentation (e.g. for README.md files) label Aug 23, 2023
@pascalgouedo
Copy link

Already done in #854
Should have been automatically merged in master as usual.
@davideschiavone it seems PR #854 and #855 didn't automatically generate a dev -> master merge request...

@davideschiavone
Copy link
Contributor

Already done in #854 Should have been automatically merged in master as usual. @davideschiavone it seems PR #854 and #855 didn't automatically generate a dev -> master merge request...

we again have failing CI - we are checking it

@MikeOpenHWGroup
Copy link
Member Author

Hi @davideschiavone. The check_target CI check is failing since this pull request is from my fork/branch, not from the dev branch to master (as is usually done for RTL updates). This PR is simply an update to a yaml file that only affects rendering of the documentation on RTD, so this CI check is not relavent.

RTD will stop supporting projects that do not make this change. Can we merge it "as is"?

@davideschiavone
Copy link
Contributor

Ok NP, thanks

@davideschiavone davideschiavone merged commit 12d0c48 into openhwgroup:master Aug 30, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideschiavone davideschiavone Awaiting requested review from davideschiavone

@pascalgouedo pascalgouedo Awaiting requested review from pascalgouedo

Assignees
No one assigned
Labels
Component:Doc For issues in the Documentation (e.g. for README.md files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeOpenHWGroup @pascalgouedo @davideschiavone