Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Questasim execution with rvfi_tracer #1240

Merged
merged 1 commit into from
May 22, 2023

Conversation

MarioOpenHWGroup
Copy link
Contributor

@MarioOpenHWGroup MarioOpenHWGroup commented May 17, 2023

The Questa execution was not working:

  • The binary was not loaded in memory.
  • The $(tb) files were not compiled, those enable the RVFI functionality.

@github-actions
Copy link
Contributor

❌ failed run, report available here.

@JeanRochCoulon JeanRochCoulon merged commit d0a4c9f into openhwgroup:master May 22, 2023
@JeanRochCoulon
Copy link
Contributor

Great @MarioOpenHWGroup !! Thank you for the contribution. It would be useful to add some Questasim jobs into core-v-verif thales CI too. Do you think it is feasible ?

@MarioOpenHWGroup
Copy link
Contributor Author

Great @MarioOpenHWGroup !! Thank you for the contribution. It would be useful to add some Questasim jobs into core-v-verif thales CI too. Do you think it is feasible ?

Yes sure, we can add a simple test to ensure that it does not break again 👍

niwis added a commit to pulp-platform/cva6 that referenced this pull request Jun 21, 2023
`elf-bin` is propagated to fesvr via the plusplus arg. Since openhwgroup#1240, running
```
make sim elf-bin=path/to/elf
```
returns
```
terminate called after throwing an instance of 'std::runtime_error'
  what():  could not open
+PRELOAD=path/to/elf (did
you misspell it? If VCS, did you forget +permissive/+permissive-off?)
```

As per the README, if preloading is needed, `make sim preload=path/to/elf` should be used
instead (https://github.com/openhwgroup/cva6/tree/master#memory-preloading),
which sets `+PRELOAD=path/to/elf`
(https://github.com/openhwgroup/cva6/blob/6c89fda0da14e188c43c818be3af15123c82fc69/Makefile#L249-L253).

Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
zarubaf pushed a commit that referenced this pull request Jun 21, 2023
`elf-bin` is propagated to fesvr via the plusplus arg. Since #1240, running
```
make sim elf-bin=path/to/elf
```
returns
```
terminate called after throwing an instance of 'std::runtime_error'
  what():  could not open
+PRELOAD=path/to/elf (did
you misspell it? If VCS, did you forget +permissive/+permissive-off?)
```

As per the README, if preloading is needed, `make sim preload=path/to/elf` should be used
instead (https://github.com/openhwgroup/cva6/tree/master#memory-preloading),
which sets `+PRELOAD=path/to/elf`
(https://github.com/openhwgroup/cva6/blob/6c89fda0da14e188c43c818be3af15123c82fc69/Makefile#L249-L253).

Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants