Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate usage of the 'proof' parameter in the credential request #345

Open
tplooker opened this issue Jun 11, 2024 · 4 comments
Open

Deprecate usage of the 'proof' parameter in the credential request #345

tplooker opened this issue Jun 11, 2024 · 4 comments
Labels
Milestone

Comments

@tplooker
Copy link
Contributor

With the introduction of #293 and the proofs parameter there is an opportunity to simplify the credential request syntax to deprecate the usage of the proof parameter and instead just use the proofs parameter.

@tplooker
Copy link
Contributor Author

The same conversation applies to the credentials vs credential parameter in the credential response syntax.

@babisRoutis
Copy link
Contributor

I think that now it is good opportunity to make this simplification, since implementers have to remove support to batch endpoint and adjust their support for the credential endpoint, in any case.

@jogu
Copy link
Contributor

jogu commented Jul 26, 2024

Removing credential would require an update to the deferred issuance endpoint that currently references that definition (but an update to deferred issuance endpoint to mention credentials is required anyway, so this is easy to solve).

@c2bo
Copy link
Member

c2bo commented Oct 21, 2024

I'd like to bump this discussion before we go to 1.0 - now is a good time to simplify and there are a few breaking changes happening anyway. The issue with deferred issuance was fixed in #391.

@Sakurann Sakurann added this to the Final 1.0 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants