-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
where in the response to include transaction_data
#174
Comments
had a discussion with QES use-case experts/implementers and there was an interesting input that option 2 might open up a new attack vector where verifier can spoof the binding between transaction data and the credential used to identify the user (assumption is that transaction_data_token in option 2 is bound to nonce and has iat):
maybe not a concern, but thought it is worth raising this. |
I'm not arguing for option 2 atm, but I was wondering if including a hash of |
Always including the transaction data in the response should solve the problem as well as eliminating the need to repeat it. |
after WG discussion leaning towards option 1, some people said they need time to think, will come back to see if there is rough consensus around option 1 later. arguments so far:
|
two options:
transaction_data
(object or string depending on the outcome of How to encode transaction_data in the presentation request #173) in the presentation, which is credential format specific (ie KB JWT in SD-JWT, session transcript in mdoc, etc).transaction_data
and is signed using the key that is used for cryptographic key binding of credential presentation to which this transaction data is bound to.Option 1 would require each credential format to define how to include transaction data in the response. Option 2 would require defining how to express when multiple transaction data types have been requested to be bound to different credentials(ie use credential A for qes_authorization and credential B for payment_confirmation).
The text was updated successfully, but these errors were encountered: