Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add redis cluster mode in option #1178

Merged
merged 1 commit into from
Oct 12, 2023
Merged

feat: add redis cluster mode in option #1178

merged 1 commit into from
Oct 12, 2023

Conversation

rfyiamcool
Copy link
Contributor

@rfyiamcool rfyiamcool commented Oct 11, 2023 •
edited by cubxxw
Loading

summary

In redis cluster mode, we only need a dns lb resolver redis cluster address, that is, an address. Then the mapping of all slot-redis instances is obtained by metadata through the cluster protocol.

So a new parameter is added, clusterMode bool.

In addition, lint changed it a little bit as a lint.

Fix: #1186

@rfyiamcool
feat: add redis cluster mode in option
ac066ac 
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 11, 2023
@kubbot
Copy link
Contributor

kubbot commented Oct 11, 2023 •
edited
Loading

CLA Assistant Lite bot 🤖 All Contributors have signed the open-im-server CLA.
The signed information is recorded 🤖here

@cubxxw
Copy link
Contributor

cubxxw commented Oct 11, 2023

@rfyiamcool 你需要签署一下 CLA，在评论中单独评论下面这句话：

I have read the CLA Document and I hereby sign the CLA

@rfyiamcool rfyiamcool temporarily deployed to openim October 11, 2023 04:34 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 11, 2023 04:34 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 11, 2023 04:34 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 11, 2023 04:34 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 11, 2023 04:34 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 11, 2023 04:34 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 11, 2023 04:34 — with GitHub Actions Inactive
@rfyiamcool
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@rfyiamcool
Copy link
Contributor Author

@rfyiamcool 你需要签署一下 CLA，在评论中单独评论下面这句话：

I have read the CLA Document and I hereby sign the CLA

done

openimbot added a commit to openim-sigs/cla that referenced this pull request Oct 11, 2023
@openimbot
@rfyiamcool has signed the CLA in openimsdk/open-im-server#1178
439b199
@cubxxw cubxxw mentioned this pull request Oct 11, 2023
Merged
@cubxxw cubxxw enabled auto-merge October 11, 2023 16:37
@cubxxw cubxxw added this pull request to the merge queue Oct 12, 2023
Merged via the queue into openimsdk:main with commit 8b649a5 Oct 12, 2023
18 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Oct 12, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cubxxw cubxxw cubxxw approved these changes

@kubbot kubbot kubbot approved these changes

@Bloomingg Bloomingg Awaiting requested review from Bloomingg Bloomingg is a code owner

@FGadvancer FGadvancer Awaiting requested review from FGadvancer FGadvancer is a code owner

@skiffer-git skiffer-git Awaiting requested review from skiffer-git skiffer-git is a code owner

@withchao withchao Awaiting requested review from withchao withchao is a code owner

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.

Incorporate Single Address Resolution in Redis Cluster Mode
3 participants
@rfyiamcool @kubbot @cubxxw