Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: reduce lock latency for localcache group #1179

Merged
merged 1 commit into from
Oct 12, 2023
Merged

optimize: reduce lock latency for localcache group #1179

merged 1 commit into from
Oct 12, 2023

Conversation

rfyiamcool
Copy link
Contributor

@rfyiamcool rfyiamcool commented Oct 11, 2023 •
edited by cubxxw
Loading

summary

The lock granularity here is a bit large, so two-stage locks are used and rpc io operations are handled independently to improve the throughput under cache miss.

Fix: #1186

@rfyiamcool
optimize: reduce lock latency for localcache group
0939b0a 
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2023
@kubbot
Copy link
Contributor

kubbot commented Oct 11, 2023 •
edited
Loading

CLA Assistant Lite bot 🤖 All Contributors have signed the open-im-server CLA.
The signed information is recorded 🤖here

@rfyiamcool
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA

@rfyiamcool
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@rfyiamcool rfyiamcool temporarily deployed to openim October 11, 2023 16:31 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 11, 2023 16:31 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 11, 2023 16:31 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 11, 2023 16:31 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 11, 2023 16:31 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 11, 2023 16:31 — with GitHub Actions Inactive
@rfyiamcool rfyiamcool temporarily deployed to openim October 11, 2023 16:31 — with GitHub Actions Inactive
@cubxxw
Copy link
Contributor

cubxxw commented Oct 11, 2023

Link #1178

@cubxxw
Copy link
Contributor

cubxxw commented Oct 11, 2023

#1186

@cubxxw cubxxw enabled auto-merge October 12, 2023 02:23
@cubxxw cubxxw added this pull request to the merge queue Oct 12, 2023
Merged via the queue into openimsdk:main with commit ba1d479 Oct 12, 2023
18 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Oct 12, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kubbot kubbot kubbot approved these changes

@cubxxw cubxxw cubxxw approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.

Incorporate Single Address Resolution in Redis Cluster Mode
3 participants
@rfyiamcool @kubbot @cubxxw