New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance hints #237

Closed
mmd-osm opened this Issue Sep 3, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@mmd-osm

mmd-osm commented Sep 3, 2017

I noticed a few issues during performance testing, which I believe are related this this code: https://github.com/opening-hours/opening_hours.js/blob/master/Makefile#L338-L356

  • You could reduce the download size by more than 50% adding something like [fee!=no][fee!=yes][lit!=no][lit!=yes]
  • Some of your queries, especially DE-NW always fail, because they use too much memory (see drolbr/Overpass-API#429). Suitable maxsize parameter setting needs to be added to your query. Code changes on Overpass side to reduce memory consumption will take much more time.
  • If your job runs a few minutes after midnight and would be very close to the point in time you want to analyze, consider removing the [date:...] setting altogether. This will significantly speed up the query, and the difference in object count is probably negligible. Also it will significantly reduce memory consumption on the server side.
  • Activate regular expressions (OVERPASS_QUERY_USE_REGEX): this was at least 40% faster during my tests.
@ypid

This comment has been minimized.

Show comment
Hide comment
@ypid

ypid Sep 3, 2017

Member

Thanks for the input! It will take me some time before I can look into this.

Member

ypid commented Sep 3, 2017

Thanks for the input! It will take me some time before I can look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment