Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings for advances notifications #75

Closed
3 tasks done
friedger opened this issue Feb 15, 2019 · 11 comments
Closed
3 tasks done

Settings for advances notifications #75

friedger opened this issue Feb 15, 2019 · 11 comments
Labels
Milestone

Comments

@friedger
Copy link
Member

friedger commented Feb 15, 2019

This issue is about adding a section in the settings view with advanced settings for notifications:

  • add a switch button to enable enriched notifications (using springrole), the value is stored in preferences
  • add an edit field with label "Excluded guests", the value is stored in preferences
  • change the label of Notification to "Enriched Notification" in the the event details if the preferences is set and if the guest list contains other guests than those excluded in the settings. Update the label as soon as a guests is added accordingly
@friedger friedger added this to the 0.7.0 milestone Feb 15, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.4 ETH (48.58 USD @ $121.45/ETH) attached to it as part of the SpringRole fund.

@gitcoinbot
Copy link

gitcoinbot commented Feb 15, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 11 months, 2 weeks from now.
Please review their action plans below:

1) leonardohof has been approved to start work.

Hi again,
Can I work on this task?

Learn more on the Gitcoin Issue Details page.

@leonardohofling
Copy link

@friedger Which component I can use for Switch? And the Preferences will be stored in the Blockstack like the Calendars?

@friedger
Copy link
Member Author

friedger commented Feb 16, 2019

@leonardohof Preferences are saved with the savePreferences(prefsAttributes) where you can just put

{richNotifEnabled:true, richNofifExclude:[friedger.id, fmdroid.id]}

It should not overwrite other values. The method is defined now in the develop branch.

@leonardohofling
Copy link

Thanks for the help.

leonardohofling added a commit to leonardohofling/oi-calendar that referenced this issue Feb 18, 2019
@leonardohofling
Copy link

#87

@leonardohofling
Copy link

This issue is about adding a section in the settings view with advanced settings for notifications:

  • add a switch button to enable enriched notifications (using springrole), the value is stored in preferences
  • add an edit field with label "Excluded guests", the value is stored in preferences
  • change the label of Notification to "Enriched Notification" in the the event details if the preferences is set and if the guest list contains other guests than those excluded in the settings. Update the label as soon as a guests is added accordingly

@friedger about the third item: Where is the Notification label?
image

leonardohofling added a commit to leonardohofling/oi-calendar that referenced this issue Feb 18, 2019
@friedger
Copy link
Member Author

@leonardohof It is in the reminder. If the reminder is triggered a notification is sent

leonardohofling added a commit to leonardohofling/oi-calendar that referenced this issue Feb 18, 2019
@leonardohofling
Copy link

@leonardohof It is in the reminder. If the reminder is triggered a notification is sent
Right. So, I'll the change the Set Reminder label.

leonardohofling added a commit to leonardohofling/oi-calendar that referenced this issue Feb 18, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.4 ETH (55.51 USD @ $138.79/ETH) has been submitted by:

  1. @leonardohof

@kar2905 please take a look at the submitted work:

  • PR by @leonardohof

friedger added a commit that referenced this issue Feb 18, 2019
…ces-notifications

Settings for advances notifications #75
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.4 ETH (55.51 USD @ $138.79/ETH) attached to this issue has been approved & issued to @leonardohof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants