8296916: RISC-V: Move some small macro-assembler functions to header file

[RealFYang]

Witnessed that there are some small macro-assembler functions located in file macroAssembler_riscv.cpp.
These are small functions which mostly contain only a single line of code. We should move them to the
corresponding header file so that they have a chance to be inlined.

Testing: Tier1 on linux-riscv64 HiFive unmatched board.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296916: RISC-V: Move some small macro-assembler functions to header file

Reviewers

• Feilong Jiang (@feilongjiang - Author)
• Yadong Wang (@yadongw - Author)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11130/head:pull/11130
$ git checkout pull/11130

Update a local copy of the PR:
$ git checkout pull/11130
$ git pull https://git.openjdk.org/jdk pull/11130/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11130

View PR using the GUI difftool:
$ git pr show -t 11130

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11130.diff

[bridgekeeper]

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealFYang The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (363966e2)
• 00: Full (47365eb2)

[feilongjiang]

Change looks good.

[yadongw]

lgtm

[RealFYang]

@feilongjiang @yadongw : Thanks for the review! Need a Review then. @shipilev : Want to take a look?

[shipilev]

I would have expected these to be moved to macroAssembler_riscv.inline.hpp, to be honest.

[shipilev]

But this is okay as well.

[openjdk]

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296916: RISC-V: Move some small macro-assembler functions to header file

Reviewed-by: fjiang, yadongwang, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• 3f2f128: 8295952: Problemlist existing compiler/rtm tests also on x86
• 6ead2b0: 8296548: Improve MD5 intrinsic for x86_64
• bd3acbe: 8297089: [BACKOUT] JDK-8297088 Update LCMS to 2.14
• 6a60d31: 8295369: Update LCMS to 2.14
• 0cbf084: 8296969: C1: PrintC1Statistics is broken after JDK-8292878
• f662a06: 8296970: Remove sysThreadAvailableStackWithSlack from hotspot-symbols
• 7357a1a: 8296889: Race condition when cancelling a request
• 87530e6: 8296913: Correct enable preview idiom in JdbLastErrorTest.java
• fafe682: 8295861: get rid of list argument in debug agent's removeNode() API
• 216c6f6: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails
• ... and 30 more: https://git.openjdk.org/jdk/compare/8eb90e2d9c4ab5975f4301dbfdb0a6d9fa036af3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealFYang]

But this is okay as well.

Thanks. I will take another look to see if we can further improve this after this one is merged.
/integrate

[openjdk]

Going to push as commit c3b285a.
Since your change was applied there have been 47 commits pushed to the master branch:

• 720c3d0: 8296932: G1: Remove unused G1RootClosures::weak_oops
• 196d021: 8297020: Rename GrowableArray::on_stack
• 5f51dff: 8296776: Stop using mtNone as marker for CHeap allocations in GrowableArray
• 499406c: 8285488: Improve DocFinder
• 97ab2c3: 8296953: Fix a typo in exception documentation
• 5e08b3f: 8296931: NMT tests slowed down considerably by JDK-8242181
• 65f7de2: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails
• 3f2f128: 8295952: Problemlist existing compiler/rtm tests also on x86
• 6ead2b0: 8296548: Improve MD5 intrinsic for x86_64
• bd3acbe: 8297089: [BACKOUT] JDK-8297088 Update LCMS to 2.14
• ... and 37 more: https://git.openjdk.org/jdk/compare/8eb90e2d9c4ab5975f4301dbfdb0a6d9fa036af3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang Pushed as commit c3b285a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.