JDK-8324169 : Remove macOS from ProblemList for CycleDMIMage.java when fix is available for JDK-8312518

[honkar-jdk]

CycleDMIMage.java passes on macOS after JDK-8312518, PR#17358. It is de-problemlisted for macOS only.

CI testing looks good.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324169: Remove macOS from ProblemList for CycleDMIMage.java when fix is available for JDK-8312518 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17493/head:pull/17493
$ git checkout pull/17493

Update a local copy of the PR:
$ git checkout pull/17493
$ git pull https://git.openjdk.org/jdk.git pull/17493/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17493

View PR using the GUI difftool:
$ git pr show -t 17493

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17493.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@honkar-jdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[honkar-jdk]

/label client

[openjdk]

@honkar-jdk
The client label was successfully added.

[mlbridge]

Webrevs

• 00: Full (37e54592)

[prrace]

it seems odd to remove macOS from the list when one of the bugs here is specifically against macOS - https://bugs.openjdk.org/browse/JDK-8274106
If the test still fails on some retina displays, then this needs to remain problem listed.
If not, then remove the reference to 8274106

Wait 7099223 is also about macOS.
So why is this test problem listed on all platforms ?
If it passes always on macOS we also should close out those bugs.
Please check it on all platforms and de-list it for all platforms that pass and if it does fail on Windows or Linux, create a bug for that platform's problems.

[honkar-jdk]

There are couple of JBS issues related to CycleDMImage.java
JDK-7099223 - listed for all platforms
JDK-8312459 - subtask to problemlist on macOS but the JBS number itself is not included in problemlist.
JDK-8274106 - The one you mentioned earlier.

Please check it on all platforms and de-list it for all platforms that pass and if it does fail on Windows or Linux, create a bug for that platform's problems.

Checking it again on all platforms.

[prrace]

7099223 was noted in 2011 (!) as failing on solaris (doesn't matter anymore) , passing on Linux (so why is linux problem listed ?) and mentions Windows (in 2011) but nothing since then.

Since 2019 it has ONLY been reported on macOS. Perhaps because it has been problem listed all that time on windows and linux :-), but now is the time to re-check all of this.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[bridgekeeper]

@honkar-jdk This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@honkar-jdk This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.