Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK-8324169 : Remove macOS from ProblemList for CycleDMIMage.java when fix is available for JDK-8312518 #17493

Closed
wants to merge 1 commit into from
Closed

JDK-8324169 : Remove macOS from ProblemList for CycleDMIMage.java when fix is available for JDK-8312518 #17493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/jdk/ProblemList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ java/awt/xembed/server/RunTestXEmbed.java 7034201 linux-all
java/awt/Modal/ModalFocusTransferTests/FocusTransferDialogsDocModalTest.java 8164473 linux-all
java/awt/Frame/DisposeParentGC/DisposeParentGC.java 8079786 macosx-all

java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java 7099223,8274106 macosx-all,linux-all,windows-all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems odd to remove macOS from the list when one of the bugs here is specifically against macOS - https://bugs.openjdk.org/browse/JDK-8274106
If the test still fails on some retina displays, then this needs to remain problem listed.
If not, then remove the reference to 8274106

Wait 7099223 is also about macOS.
So why is this test problem listed on all platforms ?
If it passes always on macOS we also should close out those bugs.
Please check it on all platforms and de-list it for all platforms that pass and if it does fail on Windows or Linux, create a bug for that platform's problems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are couple of JBS issues related to CycleDMImage.java
JDK-7099223 - listed for all platforms
JDK-8312459 - subtask to problemlist on macOS but the JBS number itself is not included in problemlist.
JDK-8274106 - The one you mentioned earlier.

Please check it on all platforms and de-list it for all platforms that pass and if it does fail on Windows or Linux, create a bug for that platform's problems.

Checking it again on all platforms.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7099223 was noted in 2011 (!) as failing on solaris (doesn't matter anymore) , passing on Linux (so why is linux problem listed ?) and mentions Windows (in 2011) but nothing since then.

Since 2019 it has ONLY been reported on macOS. Perhaps because it has been problem listed all that time on windows and linux :-), but now is the time to re-check all of this.

java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java 7099223,8274106 linux-all,windows-all
java/awt/keyboard/AllKeyCode/AllKeyCode.java 8242930 macosx-all
java/awt/FullScreen/8013581/bug8013581.java 8169471 macosx-all
java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.java 8233568 macosx-all
Expand Down