-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332085: Remove 10 year old transition check in GenerateCurrencyData tool #19183
8332085: Remove 10 year old transition check in GenerateCurrencyData tool #19183
Conversation
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 28 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
/integrate |
Going to push as commit 5ded8da.
Your commit was automatically rebased without conflicts. |
The build tool that generates the currency data had a check that throws an exception (causes a build failure) if the transition date is more than 10 years away (past/future). This caused a build failure in 8u-RI repository. Since the risk of build failure seems to exceed the potential benefit (make the data clean), removing the check is appropriate.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19183/head:pull/19183
$ git checkout pull/19183
Update a local copy of the PR:
$ git checkout pull/19183
$ git pull https://git.openjdk.org/jdk.git pull/19183/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19183
View PR using the GUI difftool:
$ git pr show -t 19183
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19183.diff
Webrev
Link to Webrev Comment