8262507: OS label and information should be in same line

[YaSuenag]

We can see OS information in VM.info dcmd and hs_err log as following. Most of information and its label are in same line, but just OS is not so.

OS:
 Windows 10 , 64 bit Build 19041 (10.0.19041.804)
OS uptime: 1 days 23:40 hours
Hyper-V role detected

CPU: total 8 (initial active 8) (8 cores per cpu, 2 threads per core) family 23 model 113 stepping 0 microcode 0x0, cx8, cmov, fxsr, ht, mmx, 3dnowpref, sse, sse2, sse3, ssse3, sse4a, sse4.1, sse4.2, popcnt, lzcnt, tsc, tscinvbit, avx, avx2, aes, clmul, bmi1, bmi2, adx, sha, fma, vzeroupper, clflush, clflushopt, hv

Memory: 4k page, system-wide physical 16309M (11935M free)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8262507: OS label and information should be in same line

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2770/head:pull/2770
$ git checkout pull/2770

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@YaSuenag The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4c36cbd)

[dholmes-ora]

Hi Yasumasa,

Please see my update to the bug report. I do not think this is an issue that needs to be "fixed" like this. The "OS:" should act as a sub-heading to cover the lines of information that follow. Some fixing of the indentation of those following lines is needed.

Thanks,
David

[mlbridge]

Mailing list message from Thomas St��fe on hotspot-runtime-dev:

On Mon, Mar 1, 2021 at 3:57 AM David Holmes <dholmes at openjdk.java.net>
wrote:

On Mon, 1 Mar 2021 01:29:23 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org>
wrote:

We can see OS information in VM.info dcmd and hs_err log as following.
Most of information and its label are in same line, but just OS is not so.

OS:
Windows 10 , 64 bit Build 19041 (10.0.19041.804)
OS uptime: 1 days 23:40 hours
Hyper-V role detected

CPU: total 8 (initial active 8) (8 cores per cpu, 2 threads per core)
family 23 model 113 stepping 0 microcode 0x0, cx8, cmov, fxsr, ht, mmx,
3dnowpref, sse, sse2, sse3, ssse3, sse4a, sse4.1, sse4.2, popcnt, lzcnt,
tsc, tscinvbit, avx, avx2, aes, clmul, bmi1, bmi2, adx, sha, fma,
vzeroupper, clflush, clflushopt, hv

Memory: 4k page, system-wide physical 16309M (11935M free)

Hi Yasumasa,

Please see my update to the bug report. I do not think this is an issue
that needs to be "fixed" like this. The "OS:" should act as a sub-heading
to cover the lines of information that follow. Some fixing of the
indentation of those following lines is needed.

Thanks,
David

I agree with David here.

A better way to fix this long term may be to make outputStream somehow
"indentation-aware", as in make current indentation a property of the
stream and apply it after every newline. Possibly combined with some sort
of stack based indentation mark. But this may be more difficult than it
sounds due to the somewhat messy outputStream coding. Probably not worth
the effort.

Cheers, Thomas

[YaSuenag]

We discuss about this in comments in JDK-8262507, and I agree with @dholmes-ora . I'm asking my colleague who has Mac to fix "OS:" as a sub heading consistently in Mac.
He will add it to JBS soon, I will withdraw this PR and will close JBS issue after that.

[YaSuenag]

My colleague @jyukutyo filed it to JBS as JDK-8262828, and he will send PR for it. So I withdraw this PR and close JBS issue.