Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252774: remove jdk.test.lib.FileInstaller action from graalunit tests #34

Closed
wants to merge 1 commit into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Sep 6, 2020

pre-Skara RFR
Hi all,

could you please review this small and trivial clean up in test/hotspot/jtreg/compiler/graalunit?
from JBS:

test/hotspot/jtreg/compiler/graalunit tests use jdk.test.lib.FileInstaller to copy ProblemList-graal.txt from test/hotspot/jtreg/ to the current working directory as ExcludeList.txt, and then run compiler.graalunit.common.GraalUnitTestLauncher w/ -exclude ExcludeList.txt.

j.t.l.FileInstaller actions aren't needed as c.g.c.GraalUnitTestLauncher interpeters -exclude's value as path to file (as oppose to the file name in current directory), so we can use ${test.root}/ProblemList-graal.txt instead of ExcludeList.txt there.

the patch modifies generateTests.sh to use ${test.root}/ProblemList-graal.txt, cleans it up (removes trailing spaces, empty @summary tag, and redundant explicit @build) and regenerates graalunit tests.

testing: test/hotspot/jtreg/compiler/graalunit on {linux,windows,macos}-x64


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252774: remove jdk.test.lib.FileInstaller action from graalunit tests

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/34/head:pull/34
$ git checkout pull/34

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2020

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 6, 2020
@openjdk
Copy link

openjdk bot commented Sep 6, 2020

@iignatev The following label will be automatically applied to this pull request: hotspot-compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 6, 2020
@iignatev
Copy link
Member Author

iignatev commented Sep 6, 2020

/reviewer add epavlova

@openjdk
Copy link

openjdk bot commented Sep 6, 2020

@iignatev
Reviewer epavlova successfully added.

@openjdk
Copy link

openjdk bot commented Sep 6, 2020

@iignatev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252774: remove jdk.test.lib.FileInstaller action from graalunit tests

Reviewed-by: shade, epavlova
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 38 commits pushed to the master branch:

  • 5b30a83: 8252778: remove jdk.test.lib.FileInstaller action from compiler/c2/stemmer test
  • 8db3335: 8247928: Refactor G1ConcurrentMarkThread for mark abort
  • 7ccf435: 8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…
  • d236cf4: 8252995: Non-PCH builds broken by JDK-8250961
  • 6a00534: 8250961: Move Universe::update_heap_info_at_gc to CollectedHeap
  • f78f780: 8252889: Obsolete -XX:+InsertMemBarAfterArraycopy
  • f933961: 8252980: comment only changes extracted from JDK-8247281
  • 4333942: 8250217: com.sun.tools.javac.api.JavacTaskImpl swallows compiler exceptions potentially producing false positive test results
  • 5166094: 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
  • 6329de4: 8248532: Every time I change keyboard language at my MacBook, Java crashes
  • ... and 28 more: https://git.openjdk.java.net/jdk/compare/5f76deb2e064ca8a48fb8a638c23aad34bf27f9c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 5b30a831334637f6335d8f2e28120736be6c0548.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 6, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2020

Webrevs

@iignatev
Copy link
Member Author

iignatev commented Sep 6, 2020

@iignatev This change now passes all automated pre-integration checks. ...

no, it does not. epavlova isn't a Reviewer in JDK project, so this PR and #33 aren't ready to be integrated. @edvbld , @rwestberg, could you please take a look?

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 8, 2020
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 10, 2020
@iignatev
Copy link
Member Author

iignatev commented Sep 10, 2020

/integrate

@openjdk openjdk bot closed this Sep 10, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 10, 2020
@openjdk
Copy link

openjdk bot commented Sep 10, 2020

@iignatev Since your change was applied there have been 38 commits pushed to the master branch:

  • 5b30a83: 8252778: remove jdk.test.lib.FileInstaller action from compiler/c2/stemmer test
  • 8db3335: 8247928: Refactor G1ConcurrentMarkThread for mark abort
  • 7ccf435: 8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…
  • d236cf4: 8252995: Non-PCH builds broken by JDK-8250961
  • 6a00534: 8250961: Move Universe::update_heap_info_at_gc to CollectedHeap
  • f78f780: 8252889: Obsolete -XX:+InsertMemBarAfterArraycopy
  • f933961: 8252980: comment only changes extracted from JDK-8247281
  • 4333942: 8250217: com.sun.tools.javac.api.JavacTaskImpl swallows compiler exceptions potentially producing false positive test results
  • 5166094: 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
  • 6329de4: 8248532: Every time I change keyboard language at my MacBook, Java crashes
  • ... and 28 more: https://git.openjdk.java.net/jdk/compare/5f76deb2e064ca8a48fb8a638c23aad34bf27f9c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 41d29b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@iignatev iignatev deleted the 8252774 branch Sep 11, 2020
biboudis pushed a commit to biboudis/jdk that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants