-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8252774: remove jdk.test.lib.FileInstaller action from graalunit tests #34
Conversation
👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into |
@iignatev The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
/reviewer add epavlova |
@iignatev |
@iignatev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 38 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
no, it does not. |
/integrate |
@iignatev Since your change was applied there have been 38 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 41d29b7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
…thod (openjdk#34) * JVM-1687: Wrong allocation state at exit point of an inlined method * Fixed regression test. --------- Co-authored-by: Xin Liu <xxinliu@amazon.com>
pre-Skara RFR
Hi all,
could you please review this small and trivial clean up in
test/hotspot/jtreg/compiler/graalunit
?from JBS:
j.t.l.FileInstaller
actions aren't needed asc.g.c.GraalUnitTestLauncher
interpeters-exclude
's value as path to file (as oppose to the file name in current directory), so we can use${test.root}/ProblemList-graal.txt
instead ofExcludeList.txt
there.the patch modifies
generateTests.sh
to use${test.root}/ProblemList-graal.txt
, cleans it up (removes trailing spaces, empty@summary
tag, and redundant explicit@build
) and regenerates graalunit tests.testing:
test/hotspot/jtreg/compiler/graalunit
on {linux,windows,macos}-x64Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/34/head:pull/34
$ git checkout pull/34