-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266426: ZHeapIteratorOopClosure does not handle native access properly #3838
Conversation
👋 Welcome back ayang! A progress list of the required criteria for merging this PR into |
@albertnetymk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/contributor add pliden |
@albertnetymk |
@albertnetymk |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds an non-trivial is_in call to each visited oop*. I'd like to see if this could instead be solved by letting the used closure "know" when it scans CLDs, and only in that case use NativeAccess.
/contributor add stefank |
@albertnetymk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@albertnetymk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 136 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thank you very much for the help on creating this patch. /integrate |
@albertnetymk Since your change was applied there have been 138 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 47d4438. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Change the inheritance hierarchy of
ZHeapIteratorOopClosure
so that we can know whether we are loading oops from in-heap or outside-heap (only CLD iteration).Progress
Issue
Reviewers
Contributors
<pliden@openjdk.org>
<eosterlund@openjdk.org>
<stefank@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3838/head:pull/3838
$ git checkout pull/3838
Update a local copy of the PR:
$ git checkout pull/3838
$ git pull https://git.openjdk.java.net/jdk pull/3838/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3838
View PR using the GUI difftool:
$ git pr show -t 3838
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3838.diff