Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278251: Enable "missing-explicit-ctor" check in the jdk.unsupported.desktop module #6708

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 3, 2021

The "missing-explicit-ctor" check was disabled by the JDK-8071961 and later was fixed by the JDK-8250853. So we can re-enable this check again.

The fix will remove the "Java.gmk" file and as a result the "jdk.unsupported.desktop" folder.

All "Pre-submit tests" builds are green.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278251: Enable "missing-explicit-ctor" check in the jdk.unsupported.desktop module

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6708/head:pull/6708
$ git checkout pull/6708

Update a local copy of the PR:
$ git checkout pull/6708
$ git pull https://git.openjdk.java.net/jdk pull/6708/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6708

View PR using the GUI difftool:
$ git pr show -t 6708

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6708.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 3, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2021

@mrserb The following labels will be automatically applied to this pull request:

  • build
  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build client labels Dec 3, 2021
@mrserb mrserb marked this pull request as ready for review Dec 4, 2021
@openjdk openjdk bot added the rfr label Dec 4, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 4, 2021

Webrevs

magicus
magicus approved these changes Dec 6, 2021
Copy link
Member

@magicus magicus left a comment

LGTM.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278251: Enable "missing-explicit-ctor" check in the jdk.unsupported.desktop module

Reviewed-by: ihse, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 70bad89: 8277497: Last column cell in the JTAble row is read as empty cell
  • 5045eb5: 8278273: Remove unnecessary exclusion of doclint accessibility checks
  • 587e540: 8210558: serviceability/sa/TestJhsdbJstackLock.java fails to find '^\s+- waiting to lock <0x[0-9a-f]+> (a java.lang.Class ...'
  • 082fdf4: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • ab78187: 8277105: Inconsistent handling of missing permitted subclasses
  • adf3952: 8277372: Add getters for BOT and card table members
  • 7c6f57f: 8275610: C2: Object field load floats above its null check resulting in a segfault
  • a885aab: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
  • 6994d80: 8278291: compiler/uncommontrap/TraceDeoptimizationNoRealloc.java fails with release VMs after JDK-8154011
  • 286a26c: 8278277: G1: Simplify implementation of G1GCPhaseTimes::record_or_add_time_secs
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/2b87c2b429f1c9f0d940795d5f74a54a20c2f5c0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 6, 2021
prrace
prrace approved these changes Dec 6, 2021
@jddarcy
Copy link
Member

@jddarcy jddarcy commented Dec 6, 2021

Not a reviewer for this particular change, but I support its goals.

@mrserb
Copy link
Member Author

@mrserb mrserb commented Dec 8, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2021

Going to push as commit 6e7b7f3.
Since your change was applied there have been 79 commits pushed to the master branch:

  • c83b781: 8278459: ProblemList javax/swing/JTree/4908142/bug4908142.java on macosx-aarch64
  • 8e8fadf: 8278428: ObjectInputStream.readFully range check incorrect
  • 5a80abf: 8272944: Use snippets in jdk.javadoc documentation
  • fb11d8f: 8272945: Use snippets in java.compiler documentation
  • 42d9b1b: 8277106: Cannot compile certain sources with --release
  • ba86dd4: 8278445: ProblemList tools/jpackage/share/IconTest.java on macosx-x64
  • 92aa75b: 8274903: Zero: Support AsyncGetCallTrace
  • 8345453: 8272392: Lanai: SwingSet2. Black background on expanding tree node
  • 9b74749: 8276660: Scalability bottleneck in java.security.Provider.getService()
  • 2478158: 8277361: java/nio/channels/Channels/ReadXBytes.java fails with OOM error
  • ... and 69 more: https://git.openjdk.java.net/jdk/compare/2b87c2b429f1c9f0d940795d5f74a54a20c2f5c0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2021

@mrserb Pushed as commit 6e7b7f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8278251 branch Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build client integrated
4 participants