Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285962: NimbusDefaults has a typo in a L&F property #8504

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented May 2, 2022

BasicLookAndFeel, BasicProgressBarUI, GTKLookAndFeel tries to find property by "ProgressBar.verticalSize" but the property defined in NimbusDefaults has a typo "vertictalSize ".
Rectified the typo.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8285962: NimbusDefaults has a typo in a L&F property

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8504/head:pull/8504
$ git checkout pull/8504

Update a local copy of the PR:
$ git checkout pull/8504
$ git pull https://git.openjdk.java.net/jdk pull/8504/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8504

View PR using the GUI difftool:
$ git pr show -t 8504

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8504.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2022

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 2, 2022
@openjdk
Copy link

openjdk bot commented May 2, 2022

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 2, 2022
@mlbridge
Copy link

mlbridge bot commented May 2, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 5, 2022

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285962: NimbusDefaults has a typo in a L&F property

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 123 new commits pushed to the master branch:

  • 5ac7186: 8282559: Allow multiple search terms in javadoc search
  • 7022543: 8286195: ProblemList test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
  • ede06c3: 8282060: RemoteRuntimeImageTest is not actually testing on JDK 8
  • dce860a: 8285947: Avoid redundant HashMap.containsKey calls in ZoneName
  • 9d2f591: 8285987: executing shell scripts without #! fails on Alpine linux
  • fd41e65: 8286115: G1: G1RemSetArrayOfCardsEntriesBase off-by-one error
  • 7e88ff8: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary
  • 81d7475: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS
  • 4a5e7a1: 8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc
  • 1bb4de2: 8285956: (fs) Excessive default poll interval in PollingWatchService
  • ... and 113 more: https://git.openjdk.java.net/jdk/compare/16a8ebbf0573b8ee75072f8120fb0d4a584cb51d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 5, 2022
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 20, 2022

Going to push as commit 6d56caf.
Since your change was applied there have been 372 commits pushed to the master branch:

  • d5d19f5: 8287013: StringConcatFactory: remove short and byte mixers/prependers
  • 828dc89: 8286893: G1: Recent card set coarsening statistics wrong
  • 6569666: 8286943: G1: With virtualized remembered sets, maximum number of cards configured is wrong
  • 40e99a1: 8285308: Win: Japanese logical fonts are drawn with wrong size
  • 890771e: 8285517: System.getenv() returns unexpected value if environment variable has non ASCII character
  • de74e0e: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable
  • 9f562ef: 8286872: Refactor add/modify notification icon (TrayIcon)
  • b089229: 8271078: jdk/incubator/vector/Float128VectorTests.java failed a subtest
  • 079312c: 8286182: [BACKOUT] x86: Handle integral division overflow during parsing
  • 7b19226: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02
  • ... and 362 more: https://git.openjdk.java.net/jdk/compare/16a8ebbf0573b8ee75072f8120fb0d4a584cb51d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 20, 2022
@openjdk openjdk bot closed this May 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 20, 2022
@openjdk
Copy link

openjdk bot commented May 20, 2022

@prsadhuk Pushed as commit 6d56caf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8285962 branch May 20, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants